New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716108 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove data reduction proxy support from Cronet

Project Member Reported by mge...@chromium.org, Apr 27 2017

Issue description

It isn't being used, so we've decided to delete it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df9e0a31bddb2e31376f1e60a60e2a8fbae83f40

commit df9e0a31bddb2e31376f1e60a60e2a8fbae83f40
Author: mgersh <mgersh@chromium.org>
Date: Fri Apr 28 02:01:16 2017

Delete Cronet data reduction proxy support from builder

This option is being removed from Cronet.

BUG= 716108 

Review-Url: https://codereview.chromium.org/2845093005
Cr-Commit-Position: refs/heads/master@{#467829}

[modify] https://crrev.com/df9e0a31bddb2e31376f1e60a60e2a8fbae83f40/tools/mb/mb_config.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f95d508c15009e62252c38701982042740289d84

commit f95d508c15009e62252c38701982042740289d84
Author: mgersh <mgersh@chromium.org>
Date: Fri Apr 28 16:59:15 2017

Delete Cronet Data Reduction Proxy integration

No one is using it, so we've decided to delete the code. The removals
from api.txt are safe because that code is known to be unused, partly
because it wouldn't have worked anyway.

BUG= 716108 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2839413003
Cr-Commit-Position: refs/heads/master@{#468029}

[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/BUILD.gn
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/DEPS
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/api.txt
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/cronet_data_reduction_proxy.cc
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/cronet_data_reduction_proxy.h
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/cronet_in_memory_pref_store.cc
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/cronet_in_memory_pref_store.h
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/cronet_url_request_context_adapter.h
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/test/assets/test/datareductionproxysuccess.txt
[delete] https://crrev.com/ad784833978af52e8552372701aa759244cf9dff/components/cronet/android/test/assets/test/datareductionproxysuccess.txt.mock-http-headers
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/test/cronet_url_request_context_config_test.cc
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/test/native_test_server.cc
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/android/test/src/org/chromium/net/NativeTestServer.java
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/url_request_context_config.h
[modify] https://crrev.com/f95d508c15009e62252c38701982042740289d84/components/cronet/url_request_context_config_unittest.cc

Comment 3 by mge...@chromium.org, Apr 28 2017

Status: Fixed (was: Started)

Sign in to add a comment