All callers of ReportSender and ErrorReporter seem to be setting this parameter to net::ReportSender::DO_NOT_SEND_COOKIES. It seems like we can remove the parameter and make this setting the default. estark: WDYT?
SGTM if all callers are using DO_NOT_SEND_COOKIES.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49c44f6ba26559359103400eb2480a832955d71f commit 49c44f6ba26559359103400eb2480a832955d71f Author: meacer <meacer@chromium.org> Date: Fri Apr 28 22:06:08 2017 Remove unused CookiePreferences from report sender and never send cookies All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES. Remove the enum altogether. BUG= 716098 Review-Url: https://codereview.chromium.org/2851493003 Cr-Commit-Position: refs/heads/master@{#468150} [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/certificate_reporting_service.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/mock_permission_report_sender.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/notification_image_reporter.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/permission_reporter.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/ssl/chrome_expect_ct_reporter.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter.h [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter_unittest.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender.cc [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender.h [modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender_unittest.cc
Comment 1 by est...@chromium.org
, Apr 27 2017Status: Available (was: Untriaged)