New issue
Advanced search Search tips

Issue 716098 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove cookies_preference parameter from ErrorReporter

Project Member Reported by mea...@chromium.org, Apr 27 2017

Issue description

All callers of ReportSender and ErrorReporter seem to be setting this parameter to net::ReportSender::DO_NOT_SEND_COOKIES. It seems like we can remove the parameter and make this setting the default. estark: WDYT?
 

Comment 1 by est...@chromium.org, Apr 27 2017

Labels: Team-Security-UX
Status: Available (was: Untriaged)
SGTM if all callers are using DO_NOT_SEND_COOKIES.

Comment 2 by mea...@chromium.org, Apr 27 2017

Cc: -mea...@chromium.org
Owner: mea...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c44f6ba26559359103400eb2480a832955d71f

commit 49c44f6ba26559359103400eb2480a832955d71f
Author: meacer <meacer@chromium.org>
Date: Fri Apr 28 22:06:08 2017

Remove unused CookiePreferences from report sender and never send cookies

All non-test callers of ReportSender use CookiePreferences::DO_NOT_SEND_COOKIES.
Remove the enum altogether.

BUG= 716098 

Review-Url: https://codereview.chromium.org/2851493003
Cr-Commit-Position: refs/heads/master@{#468150}

[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/certificate_reporting_service.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/mock_permission_report_sender.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/safe_browsing/permission_reporter.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/ssl/chrome_expect_ct_reporter.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter.h
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/components/certificate_reporting/error_reporter_unittest.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender.cc
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender.h
[modify] https://crrev.com/49c44f6ba26559359103400eb2480a832955d71f/net/url_request/report_sender_unittest.cc

Comment 4 by mea...@chromium.org, Apr 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment