New issue
Advanced search Search tips

Issue 716097 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 716094



Sign in to add a comment

Make a version of the WebView interstitials that works in chrome://interstitials

Project Member Reported by f...@chromium.org, Apr 27 2017

Issue description

It's helpful to be able to manually test & debug HTML/CSS/JS for interstitials by giving them a home at chrome://interstitials. We'll need to make a Blocking Page for testing the WebView interstitials in Chrome, but it should still be convenient to be able to test them this way.


 
@felt, any suggestions on how to structure the code to support the quiet design?

This was my (disorganised) line of thinking:
+ Alter BaseBlockingPage constructor to check for a type so that the appropriate baseSafeBrowsingErrorUI can can be created. 
+ Amend SecurityInterstitialPage::GetHTMLContents to check for the type of interstitial and use the appropriate template

For the tests should I just add a section to: safe_browsing_blocking_page_test.cc

Thanks.
Status: Fixed (was: Assigned)

Sign in to add a comment