We currently removed the checkbox for WebView, but I thought we actually wanted to bring it back (see crbug/688629). Am I mistaken?

The UI deck says no checkbox. Emily can you please clarify

(also technically the checkbox isn't removed for WebView... it's removed by default from the base class and then instantiating that base class for WebViews, which is not really how we should be doing it ;)

Just chatted about this with Jialiu. 

We do want the checkbox reporting as soon as possible, however, the reporting will not be ready for M60, and we do not have an approved opt-in string yet, so in an effort to get something UI approval-ready, we took it out of the mocks. It does not make sense to show the checkbox in the UI until we support reporting, right?

From sgurun in a comment on the deck "For first version of safebrowsing there is no checkbox. No reporting supported. We will add reporting later"

I don't deeply understand how WebView can "turn off" the checkbox, but maybe that means we should indeed add something on the Chrome side, and keep it "turned off" in WebView until we're ready to receive the reports and have a finalized string.

Currently, disabling opt-in text and checkbox is achieved by setting 
SBErrorDisplayOptions::is_extended_reporting_opt_in_allowed to false. 

Thanks for clarifying, Emily! SGTM, just wanted to make sure we weren't intending to remove it long-term (wasn't sure how close Tim had gotten to implementing it).

Yeah, that's how we disable it right now. Fun fact, chrome actually disables it too for incognito mode (and possibly other cases as well).

Just to clarify confusion, we are doing the project in phases. Initial phase, our goal is to have a basic safebrowsing up and working. We don't have the reporting mechanism implemented yet.

Once reporting is implemented for WebView, we can enable it. Our UI and requirements are going to be different from Chrome (each time user needs to give consent). 

Honestly we are not targeting M60 for that. It will come, whenever the implementation is ready.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5290088f4545b02abf2d0d6064d685ee0c7b50e2

commit 5290088f4545b02abf2d0d6064d685ee0c7b50e2
Author: edwardjung <edwardjung@chromium.org>
Date: Tue May 09 13:41:24 2017

Support interstitials with no primary button.

Current use case will be for showing interstitials in WebView, where 'Back to safety' isn't available.

BUG= 716096 

Review-Url: https://codereview.chromium.org/2858043004
Cr-Commit-Position: refs/heads/master@{#470311}

[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/content/security_interstitial_controller_client.cc
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/content/security_interstitial_controller_client.h
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/core/browser/resources/interstitial_v2.js
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/core/controller_client.h
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/core/safe_browsing_error_ui.cc
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/components/security_interstitials/core/ssl_error_ui.cc
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/ios/chrome/browser/interstitials/ios_chrome_controller_client.h
[modify] https://crrev.com/5290088f4545b02abf2d0d6064d685ee0c7b50e2/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7395fb0478f05e183d9aa649ef72e859987c84f

commit d7395fb0478f05e183d9aa649ef72e859987c84f
Author: edwardjung <edwardjung@chromium.org>
Date: Fri May 12 23:13:29 2017

Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI

In preparation for adding a 'quiet' version of the Safe Browsing interstitial UI.

BUG= 716096 

Review-Url: https://codereview.chromium.org/2852333003
Cr-Commit-Position: refs/heads/master@{#471479}

[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/android_webview/browser/aw_safe_browsing_blocking_page.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/android_webview/browser/aw_safe_browsing_blocking_page.h
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/safe_browsing/base_blocking_page.h
[modify] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/security_interstitials/core/BUILD.gn
[add] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/security_interstitials/core/base_safe_browsing_error_ui.cc
[rename] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/security_interstitials/core/base_safe_browsing_error_ui.h
[rename] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/security_interstitials/core/safe_browsing_loud_error_ui.cc
[add] https://crrev.com/d7395fb0478f05e183d9aa649ef72e859987c84f/components/security_interstitials/core/safe_browsing_loud_error_ui.h

From the email thread we need to make serve a different learn more link for WenView.

https://support.google.com/chrome/?p=cpn_safe_browsing_wv  

Consensus was to provide an additional parameter in SBErrorDisplayOptions to trigger the different link.

Edward, this should be fixed in crbug/723125

re #12: Thanks!