New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716095 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 716094



Sign in to add a comment

Create Quiet (gray) version of small-size interstitials

Project Member Reported by f...@chromium.org, Apr 27 2017

Issue description

- Make the HTML/JS/CSS
- Hook it up to a wrapper page (C++)
 
Labels: SafeBrowsing-Triaged
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f

commit f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f
Author: edwardjung <edwardjung@chromium.org>
Date: Fri May 19 10:43:22 2017

Add quiet safe browsing interstitial for WebView

BUG= 716095 

Review-Url: https://codereview.chromium.org/2854263003
Cr-Commit-Position: refs/heads/master@{#473150}

[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/OWNERS
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/neterror/resources/neterror.html
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/resources/security_interstitials_resources.grdp
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/BUILD.gn
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/base_safe_browsing_error_ui.h
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/extended_reporting.js
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/images/blocked.svg
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_common.css
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_common.js
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_v2.css
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_v2.html
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_v2.js
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.css
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.js
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/safe_browsing_loud_error_ui.cc
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/safe_browsing_loud_error_ui.h
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
[add] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials/core/safe_browsing_quiet_error_ui.h
[modify] https://crrev.com/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f/components/security_interstitials_strings.grdp

Status: Fixed (was: Started)
Labels: WebView-SafeBrowsing

Sign in to add a comment