Issue 715587 has been merged into this issue.

Hi wuandy@, this might be a good next task for you to get familiar with the code, you can implement it for Android,

Question, right now in shipping summary section, it is something like this:
<name>
<address>
<phone>
<shipping option>

each on a separate line.

after the separation of shipping address and shipping option, should i still keep them in separate lines? The default behavior of OptionSection is to display on a single line, so if I don't do anything, it might be something like:

Shipping Address----
<name><addres(truncated..)
Shipping Option----
<option>

Do you have a screengrab of an example to take a look at? 

MY feeling they should be separate as they are different things. Also it would allow the highlighting of a cost added to the shipping if it isn't free. 

Perhaps showing the cost in bold might help as well. The general goal is to be as transparent as possible. 

screenshots attached..which one feels right?

Deleted: before-separation.png 128 KB

	before-separation.png 128 KB View Download

Deleted: separation-address-option-single-line.png 135 KB

	separation-address-option-single-line.png 135 KB View Download

Deleted: separation-everything-multiple-line.png 134 KB

	separation-everything-multiple-line.png 134 KB View Download

Deleted: separation-address-multiple-line.png 139 KB

	separation-address-multiple-line.png 139 KB View Download

separation-address-multiple-line looks great to me.

I wonder if it's worth right aligning the cost, so it's scannable along the right edge, as is the order total. This is a huge improvement in any case.

Yep, LGTM to me as well. Thanks!

Great improvement, if we could right align the cost so it fits under the total that would be amazing.

Thank you so much for working on this.

Ps separation-address-multiple-line works lgtm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05d0f177c30e5ad1b0309b46b69a288336012a8

commit f05d0f177c30e5ad1b0309b46b69a288336012a8
Author: wuandy <wuandy@chromium.org>
Date: Mon May 29 19:31:43 2017

separate shipping address and option on PR bottom sheet.

Detailed summary:
1. replace ShippingSummarySection with ShippingAddressSection and
   ShippingOptionSection in bottom sheet.
2. ShippingAddressSection will display address in multiple lines.
3. Behaviors of expanded sheet is not changed.

Note: There will be another CL to align shipping code to the right.
      This CL is already big.

BUG= 716055 

Review-Url: https://codereview.chromium.org/2908483003
Cr-Commit-Position: refs/heads/master@{#475373}

[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/java_sources.gni
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[rename] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressAndOptionTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressChangeTest.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/f05d0f177c30e5ad1b0309b46b69a288336012a8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java

how it looks like now

Deleted: Screenshot_1496242361.png 138 KB

	Screenshot_1496242361.png 138 KB View Download

That looks great to me.

LGTM!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd06835c3db030fb9ffeff153df5d75006192d10

commit bd06835c3db030fb9ffeff153df5d75006192d10
Author: wuandy <wuandy@chromium.org>
Date: Wed Jun 07 18:40:07 2017

Split shipping option name and cost on bottom sheet.

On payment request bottom sheet, this change will align shipping
cost to the right, such that it will be on the same column as
total cost, and should be easier for user to scan through quickly.

BUG= 716055 

Review-Url: https://codereview.chromium.org/2914503002
Cr-Commit-Position: refs/heads/master@{#477711}

[modify] https://crrev.com/bd06835c3db030fb9ffeff153df5d75006192d10/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/bd06835c3db030fb9ffeff153df5d75006192d10/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/bd06835c3db030fb9ffeff153df5d75006192d10/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressAndOptionTest.java
[modify] https://crrev.com/bd06835c3db030fb9ffeff153df5d75006192d10/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/bd06835c3db030fb9ffeff153df5d75006192d10/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java