Remove [Open WebAPK] menu item from app menu |
||||
Issue descriptionIt can take up to 50ms to verify whether a WebAPK is installed. Currently, we check whether a WebAPK is installed whenever we show the app menu in order to determine whether the add-to-homescreen menu item should say "Open WebAPK" In order to not slow the Chrome UI down, we will need to cache the WebAPK package names. The cache may be incorrect. It may either incorrectly think that a WebAPK is installed or incorrectly think that a WebAPK is not installed. I suggest removing the logic which makes the "Add to Home screen" app menu item say "Open WebAPK" when a WebAPK is installed. - A user visiting a PWA in Chrome should be very rare due to deep linking (They would have to enter the PWA's URL in the omnibox) - WebappDataStorage having a possibily incorrect value of whether the WebAPK is installed makes the "Open WebAPK" menu item less useful
,
Apr 27 2017
,
Apr 27 2017
,
Apr 28 2017
My vaguely disorganised thoughts: - how is the 50ms calculated? Debug or non-debug build? What device? Is it an average or a max? If it's "up to 50ms", what does it normally take? - showing nothing in the menu also requires checking whether a WebAPK is installed. That means the only option would be to always unconditionally show "Add to home screen" in the menu - showing "Add to home screen" in the menu when a WebAPK is already installed seems pretty sad from a product perspective - the fact that we know whether or not a WebAPK is installed is a huge advantage over legacy PWA shortcuts and we should try and leverage that whereever we can - keeping the cache up to date could be done with a deferred startup task? Questions: - how often will users navigate to URLs which have installed WebAPKs? Most navigations aside from direct omnibox navs are intercepted right? - how often will the cache get out of date? If we lazily update it in a DeferredStartupTask and on WebAPK installation / uninstallation will that be sufficient? |
||||
►
Sign in to add a comment |
||||
Comment 1 by pkotw...@chromium.org
, Apr 27 2017Status: Assigned (was: Untriaged)