Issue metadata
Sign in to add a comment
|
revive chrome/browser/profiles/profile_destroyer_unittest.cc |
||||||||||||||||||||||||
Issue descriptionchrome/browser/profiles/profile_destroyer_unittest.cc isn't in any build files. It doesn't compile, and if I make it compile (https://codereview.chromium.org/2842333004 ) the tests therein fail.
,
May 3 2017
,
Jun 12 2017
Hrm, not sure why I'm the owner?
,
Jun 12 2017
I can't remember and can't figure out why I made you the owner; doesn't look like a very good choice now that I try to retrace my steps, sorry :-) mad, you added the test in https://codereview.chromium.org/9420036 but didn't add it to any build file back then -- can I give this to you?
,
Jun 12 2017
Ho, yeah, sure, I don't remember why this was never actually turned on. I can take a look and see if it's not rotten too much since then.
,
Jun 19 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Apr 27 2017Failure looks like so: thakis@thakis:~/src/chrome/src$ out/gn/unit_tests --gtest_filter=ProfileDestroyer* IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = ProfileDestroyerTest.DelayProfileDestruction:ProfileDestroyerTest.DelayOriginalProfileDestruction [==========] Running 2 tests from 1 test case. [----------] Global test environment set-up. [----------] 2 tests from ProfileDestroyerTest [ RUN ] ProfileDestroyerTest.DelayProfileDestruction ../../chrome/browser/profiles/profile_destroyer_unittest.cc:114: Failure Value of: off_the_record_profile_->destroyed_otr_profile_ Actual: false Expected: true [ FAILED ] ProfileDestroyerTest.DelayProfileDestruction (948 ms) [ RUN ] ProfileDestroyerTest.DelayOriginalProfileDestruction ../../chrome/browser/profiles/profile_destroyer_unittest.cc:137: Failure Expected: (TestingOriginalDestructionProfile::kNull) != (TestingOriginalDestructionProfile::living_instance_), actual: NULL vs NULL ../../chrome/browser/profiles/profile_destroyer_unittest.cc:154: Failure Value of: TestingOriginalDestructionProfile::living_instance_ Actual: NULL Expected: main_profile Which is: 0x10e0aa497120 Received signal 11 <unknown> 000000000000 #0 0x0000039682a7 base::debug::StackTrace::StackTrace() #1 0x000003967e1f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f7ebc996330 <unknown> #3 0x0000039ade50 base::SupportsUserData::GetUserData() #4 0x000002468b07 content::(anonymous namespace)::GetSiteProcessMapForBrowserContext() #5 0x00000245fb66 content::RenderProcessHostImpl::UnregisterHost() #6 0x0000031ab233 content::MockRenderProcessHost::Cleanup() #7 0x000000b97b7a ProfileDestroyerTest_DelayOriginalProfileDestruction_Test::TestBody() #8 0x000003720fe6 testing::Test::Run() #9 0x000003721ac0 testing::TestInfo::Run() #10 0x000003721fe7 testing::TestCase::Run() #11 0x000003729027 testing::internal::UnitTestImpl::RunAllTests() #12 0x000003728ca7 testing::UnitTest::Run() #13 0x000003110de1 base::TestSuite::Run() #14 0x00000311280a base::(anonymous namespace)::LaunchUnitTestsInternal() #15 0x0000031126d4 base::LaunchUnitTests() #16 0x00000310bd9a main #17 0x7f7eb60fef45 __libc_start_main #18 0x000000648e4d <unknown> r8: 000010e0a925cd80 r9: 000000000000000b r10: 0000000000000004 r11: 0000000000000004 r12: 000010e0a90f9120 r13: 00000000089e4628 r14: 000010e0aa497120 r15: 0000000000000004 di: 000010e0aa497130 si: 000000000768ec60 bp: 000000005902054a bx: 000010e0aa468540 dx: 666f2065756c6156 ax: 666f2065756c6156 cx: 000010e0aa497130 sp: 00007ffea0106528 ip: 00000000039ade50 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. [1/2] ProfileDestroyerTest.DelayProfileDestruction (948 ms) [2/2] ProfileDestroyerTest.DelayOriginalProfileDestruction (CRASHED) 1 test failed: ProfileDestroyerTest.DelayProfileDestruction (../../chrome/browser/profiles/profile_destroyer_unittest.cc:87) 1 test crashed: ProfileDestroyerTest.DelayOriginalProfileDestruction (../../chrome/browser/profiles/profile_destroyer_unittest.cc:117)