New issue
Advanced search Search tips

Issue 716029 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

chrome_public_test_apk execution time regression on release builds

Project Member Reported by jbudorick@chromium.org, Apr 27 2017

Issue description

Splitting from https://bugs.chromium.org/p/chromium/issues/detail?id=715972#c8

It seems likely that this is related to my change yesterday that enabled multidex builds of chrome_public_test_apk: https://chromium.googlesource.com/chromium/src/+/78730f18fc734d034e44d0dc63091562be82edae
 
Status: Started (was: Assigned)
Confirmed that this is multidex locally.
For some reason, the test-multidex keeps getting nuked during execution, so we have to extract the secondary dexes in *each* test. :(
This is https://codesearch.chromium.org/chromium/src/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java?rcl=3531cd6ab4ee74146c2a0fd834a54c71c9c4178f&l=40, which currently deletes both the directory into which we extract secondary dexes and the SharedPreferences that MultiDex uses to save the hashes of dex files it has extracted. This issue isn't new -- it likely has been affecting debug builds of chrome_public_test_apk, where the app is multidex, for a while -- but it is newly affecting the trybots.

https://codereview.chromium.org/2854503002/ contains a fix.
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e4d367d46aa8da9c8e29e66388f6368d68fca7

commit 36e4d367d46aa8da9c8e29e66388f6368d68fca7
Author: jbudorick <jbudorick@chromium.org>
Date: Mon May 01 22:35:55 2017

Revert of [Android] Keep extracted secondary dex files when clearing data in tests. (patchset #2 id:20001 of https://codereview.chromium.org/2854503002/ )

Reason for revert:
primary suspect for  crbug.com/717267 

Original issue's description:
> [Android] Keep extracted secondary dex files when clearing data in tests.
>
> BUG= 716029 
>
> Review-Url: https://codereview.chromium.org/2854503002
> Cr-Commit-Position: refs/heads/master@{#468356}
> Committed: https://chromium.googlesource.com/chromium/src/+/039ec1ad2eaec6f13bfdda8cb3ac5e5d8cdc32b3

TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 716029 

Review-Url: https://codereview.chromium.org/2849323002
Cr-Commit-Position: refs/heads/master@{#468460}

[modify] https://crrev.com/36e4d367d46aa8da9c8e29e66388f6368d68fca7/base/BUILD.gn
[modify] https://crrev.com/36e4d367d46aa8da9c8e29e66388f6368d68fca7/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumRunnerCommon.java
[modify] https://crrev.com/36e4d367d46aa8da9c8e29e66388f6368d68fca7/chrome/test/android/BUILD.gn
[modify] https://crrev.com/36e4d367d46aa8da9c8e29e66388f6368d68fca7/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java

Status: Started (was: Fixed)
Status: Fixed (was: Started)

Sign in to add a comment