Uninitialized pointers in quic_compressed_certs_cache.cc
Reported by
sslu...@akamai.com,
Apr 27 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/603.1.30 (KHTML, like Gecko) Version/10.1 Safari/603.1.30 Steps to reproduce the problem: Code inspection. What is the expected behavior? What went wrong? Pointers client_common_set_hashes and client_cached_cert_hashes are not initialized in constructor QuicCompressedCertsCache::UncompressedCerts::UncompressedCerts(). This minor issue was found by coverity. Did this work before? N/A Chrome version: 58.0.3029.81 (64-bit) Channel: n/a OS Version: OS X 10.11.6 Flash Version:
,
Apr 27 2017
There is no recent changes in - quic_compressed_certs_cache.cc, looping Ryan for further updates.
,
Apr 28 2017
,
Apr 28 2017
zhongyi@ please confirm whether this is a blocker for any stable releases. I am tagging for a fix for M60, please adjust if needed.
,
Apr 28 2017
This code has been there for a while, shouldn't be a ReleaseBlock, but I do have a CL to fix this. https://codereview.chromium.org/2848883006/
,
Apr 28 2017
Great Thanks for the update.
,
Apr 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbe2663c06b2836e528013a90269cf8bf9511820 commit dbe2663c06b2836e528013a90269cf8bf9511820 Author: zhongyi <zhongyi@chromium.org> Date: Sat Apr 29 03:15:53 2017 relnote: initialize client_common_set_hashes and client_cached_cert_hashes to nullptr in default QuicCompressedCertsCache::UncompressedCerts constructor. BUG= 716026 Review-Url: https://codereview.chromium.org/2848883006 Cr-Commit-Position: refs/heads/master@{#468220} [modify] https://crrev.com/dbe2663c06b2836e528013a90269cf8bf9511820/net/quic/core/crypto/quic_compressed_certs_cache.cc
,
Apr 29 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rsesek@chromium.org
, Apr 27 2017