I thought we had a fallback to the URL (without path maybe?) for that case? Maybe that's just in the RemoteSuggestionsProvider?

The UI does not do anything special with titles, it just sets what the backend returns. And according to the bookmarks provider implementation[1] the title is just whatever the user set it to, which no fallback.

An option to be consistent with desktop (which just removes the title[2]), would be to just remove the empty space.

Or as you said, the backend could fallback to the URL when the title is empty.


And FYI, on mobile it's currently not possible to create/edit a bookmark and set an empty title. The UI blocks that.


[1]: https://cs.chromium.org/chromium/src/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc?sq=package:chromium&l=278&dr=C
[2]: https://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-bookmarks-toolbar-tips.jpg

I played around with it and got it to this. 
Let me know what you think.
Screenshot is on Nexus 5.

Deleted: screenshot-060f1f5d13c85a28-20170428T104451.png 162 KB

	screenshot-060f1f5d13c85a28-20170428T104451.png 162 KB View Download

Thanks folks!

This is definitely an improvement. That said - ideally this case wouldn't happen (we should prioritize content with more complete sets of information). Can you help me understand how we're ending up with these states, and whether they will go away in the Chrome Home (no bookmarks) world?

This happens when you set a bookmark from Chrome on Desktop and remove the title so that only the icon is shown in the bookmarks tab as in the screenshot below. When this bookmark gets transferred on your phone, we get this case :)

Deleted: Screenshot from 2017-04-28 12:47:07.png 7.9 KB

	Screenshot from 2017-04-28 12:47:07.png 7.9 KB View Download

Thanks Galina! This seems like a great solution for the case you described. :) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e04941a0e5810c69846b52f664efae23431b1458

commit e04941a0e5810c69846b52f664efae23431b1458
Author: galinap <galinap@google.com>
Date: Fri Apr 28 15:29:49 2017

Removed whitespace when no headline is set in a snippet article.

Screenshots at
https://drive.google.com/drive/folders/0B7eRCSITD4qmelN0aEFMQXNwNTA?usp=sharing

BUG= 716022 

Review-Url: https://codereview.chromium.org/2849523004
Cr-Commit-Position: refs/heads/master@{#468007}

[modify] https://crrev.com/e04941a0e5810c69846b52f664efae23431b1458/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java