New issue
Advanced search Search tips

Issue 715987 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Decouple PasswordReuseDetector from PasswordStore

Project Member Reported by dvadym@chromium.org, Apr 27 2017

Issue description

Currently PasswordStore owns PasswordReuseDetector. In principle PasswordReuseDetector can be used without PasswordStore created (for example for checking a sync password). Atm it's not the problem, since PasswordStore is created anyway, but in future it might change. This CL for tracking work for decoupling of PasswordReuseDetector from PasswordStore.
 

Comment 1 by vabr@chromium.org, Apr 27 2017

Labels: -Type-Bug Type-Task
More context: https://codereview.chromium.org/2846823002/#msg10

Comment 2 by vabr@chromium.org, Jun 14 2017

Status: Assigned (was: Available)
Could we make it clearer what is needed to be done?

I understand that PasswordReuseDetector needs to become a KeyedService, and depend on PasswordStore, because it listens to changes in stored passwords.

Are there more issues to solve?


(Also marking as assigned, because dvadym@ plans to work on this at some point.)

Comment 3 by dvadym@chromium.org, Jun 14 2017

1.PasswordReuseDetector becomes KeyedService.
2.Ensure that initialization/destroying of PasswordReuseDetector and PasswordStore is in correct order (taking into consideration that both classes are multi-threaded).
3.PasswordReuseDetector is extended from single-thread class, to be able to work on multiple thread i.e.
 - to add runners for UI and background thread (DB thread?, should be decided).
 - introduce logic for switching threads according to which thread is appropriate for which operation
 - moved HashPasswordManager to PasswordReuseDetector
4.Expose PasswordReuseDetector to clients, replace all callsites and clean all PasswordReuseDetector traces from PasswordStore 
5.Move all PasswordStore tests related to password reuse to PasswordReuseDetector tests
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment