New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715981 link

Starred by 1 user
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug



Sign in to add a comment

First navigated tab for child account get closed

Project Member Reported by bauerb@chromium.org, Apr 27 2017 
Steps to reproduce:
0) Add a child account to a device, clear all data in Chrome
1) Directly open a site that's filtered by SafeSearch (e.g. by entering it into the GSA search box)
2) Chrome opens; go through the First Run Experience

Expected: The page loads briefly, and is blocked after a few seconds.
Actual: The page loads briefly, then the whole tab closes.

See also b/36038368 for an internal bug report.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3483d15c1e3cec604c66663f19654a271bfe77ec

commit 3483d15c1e3cec604c66663f19654a271bfe77ec
Author: bauerb <bauerb@chromium.org>
Date: Tue May 02 09:54:28 2017

Avoid showing the supervised user block interstitial more than once

With asynchronous checks, it can happen that multiple checks return that
the current page should be blocked. When trying to show an interstitial
page over another existing one, the old interstitial page automatically
is closed, which for the case of the supervised user interstitial would
close the whole tab if there is no navigation to go back to. Add a flag
in SupervisedUserNavigationObserver that stores whether an interstitial
is currently showing, and clear it when the interstitial is closed.

Because the SupervisedUserNavigationObserver is now used to store state,
it is required in order to show the interstitial, so the navigation will
now fail if the SupervisedUserNavigationObserver for a WebContents is
missing.

Also, remove the case where the interstitial immediately proceeds,
because the URL filter is always checked on the UI thread.

BUG= 715981 

Review-Url: https://codereview.chromium.org/2845053002
Cr-Commit-Position: refs/heads/master@{#468591}

[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_browsertest.cc
[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_interstitial.h
[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_navigation_observer.h
[modify] https://crrev.com/3483d15c1e3cec604c66663f19654a271bfe77ec/chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc

Comment 2 by bauerb@chromium.org, May 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment