"FileDownloaderTest.DontOverwrite" is flaky |
||||||
Issue description"FileDownloaderTest.DontOverwrite" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBGaWxlRG93bmxvYWRlclRlc3QuRG9udE92ZXJ3cml0ZQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 27 2017
Suspect https://codereview.chromium.org/2835303002 (the last one to touch file_downloader_unittest.cc and related to TaskScheduler).
,
Apr 27 2017
The CL from the comment above touched OnURLFetchComplete in FileDownloader, basically adding base::CreateTaskRunnerWithTraits. Trying to revert.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfd5b6f49e5382da44646018e2471a3e9f15f96f commit dfd5b6f49e5382da44646018e2471a3e9f15f96f Author: vitaliii <vitaliii@chromium.org> Date: Thu Apr 27 11:33:18 2017 Revert of Use TaskScheduler instead of blocking pool in file_downloader.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2835303002/ ) Reason for revert: "FileDownloaderTest.DontOverwrite" is flaky. crbug.com/715964 Original issue's description: > Use TaskScheduler instead of blocking pool in file_downloader.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG= 667892 > R=asanka@chromium.org > > Review-Url: https://codereview.chromium.org/2835303002 > Cr-Commit-Position: refs/heads/master@{#467397} > Committed: https://chromium.googlesource.com/chromium/src/+/4f0ba69f0ae32dc9e48fc021852585abb0df35b5 TBR=asanka@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 667892 , 715964 Review-Url: https://codereview.chromium.org/2847553004 Cr-Commit-Position: refs/heads/master@{#467638} [modify] https://crrev.com/dfd5b6f49e5382da44646018e2471a3e9f15f96f/chrome/browser/net/file_downloader.cc [modify] https://crrev.com/dfd5b6f49e5382da44646018e2471a3e9f15f96f/chrome/browser/net/file_downloader_unittest.cc
,
Apr 27 2017
,
Apr 27 2017
It looks like failures when running a CQ dry run on the first patch set of my CL were reported as flakes. I fixed the failures in the second patch set. I landed the second patch set. And my CL was reverted because of flakes in the first patch set. E.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/439029 is linked from https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBGaWxlRG93bmxvYWRlclRlc3QuRG9udE92ZXJ3cml0ZQw and from https://codereview.chromium.org/2835303002/#ps1 Also, the same linux_chromium_rel_ng test is linked 3 times from https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/439401
,
Apr 27 2017
I am sorry for missing that the failures were in the first patch-set and happened all at the same time.
,
Apr 27 2017
Normally chromium-try-flakes will file bugs for flaky tests that have flaked at least 3 times in the last 24 hours. It seems that in this particular case all these flakes have happened on the 1st patchset of your CL, but that patchset did not land. Normally that does not happen since a flake is detected only when there is a passing and a failing build and patchsets which have green builds end up in the tree. Looks like here you've used a dry run first, which passed and then a full run, which failed. This is a corner-case that chromium-try-flakes does not handle yet, sorry for the false positive. I think the solution here would be to only file a bug if a flake has happened on at least 2 different patchsets. I am going to close this bug as WontFix and this suggestion to issue 583446. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vitaliii@chromium.org
, Apr 27 2017