New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715963 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 829310



Sign in to add a comment

"CreateNewFolder/FileManagerBrowserTest.Test/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 27 2017

Issue description

"CreateNewFolder/FileManagerBrowserTest.Test/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOAsSBUZsYWtlIi1DcmVhdGVOZXdGb2xkZXIvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzAM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Error log:
=== START ===
[ RUN      ] CreateNewFolder/FileManagerBrowserTest.Test/0
[16289:16289:0426/104331.262130:9206615239:WARNING:diagnostics_writer.cc(209)] [FAIL] 008 PathUserData (Cannot obtain size for: /b/s/w/ithqH7Ab/.org.chromium.Chromium.7lEkXH/dSKlZab)
[16289:16289:0426/104331.262265:9206615304:WARNING:diagnostics_writer.cc(209)] [FAIL] 007 PathLocalState (Path not found: /b/s/w/ithqH7Ab/.org.chromium.Chromium.7lEkXH/dSKlZab/Local State)
[16289:16289:0426/104331.262407:9206615446:WARNING:diagnostics_writer.cc(209)] [FAIL] 013 JSONPreferences (File not found)
[16289:16289:0426/104331.262427:9206615465:WARNING:diagnostics_writer.cc(209)] [FAIL] 013 JSONLocalState (File not found)
[16289:16289:0426/104331.262455:9206615493:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityWebData (File not found)
[16289:16289:0426/104331.262474:9206615513:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityCookie (File not found)
[16289:16289:0426/104331.262499:9206615537:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityHistory (File not found)
[16289:16289:0426/104331.263760:9206616799:WARNING:diagnostics_writer.cc(209)] Finished 18 tests.
[16289:16289:0426/104331.263788:9206616827:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Install type
[16289:16289:0426/104331.263802:9206616840:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Chrome version test
[16289:16289:0426/104331.263818:9206616856:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: User data path
[16289:16289:0426/104331.263828:9206616866:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Local state path
[16289:16289:0426/104331.263838:9206616876:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: App dictionaries directory path
[16289:16289:0426/104331.263848:9206616886:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Resources path
[16289:16289:0426/104331.263859:9206616897:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Available disk space
[16289:16289:0426/104331.263869:9206616908:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: User preferences integrity
[16289:16289:0426/104331.263880:9206616918:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Local state integrity
[16289:16289:0426/104331.263891:9206616929:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Bookmark file
[16289:16289:0426/104331.263902:9206616941:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Web Data database
[16289:16289:0426/104331.263913:9206616951:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Cookie database
[16289:16289:0426/104331.263923:9206616961:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Favicons database
[16289:16289:0426/104331.263938:9206616977:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: History database
[16289:16289:0426/104331.263949:9206616988:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Top Sites database
[16289:16289:0426/104331.263961:9206616999:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Database tracker database
[16289:16289:0426/104331.263970:9206617008:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: NSS certificate database
[16289:16289:0426/104331.263976:9206617014:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: NSS Key database
[16289:16289:0426/104331.263981:9206617019:WARNING:diagnostics_writer.cc(209)] Finished All Recovery operations.
=== END ===
Cc: hirono@chromium.org
Owner: yoshiki@chromium.org
Status: Assigned (was: Untriaged)
The CL is https://codereview.chromium.org/2848613002.
It is being submitted.

Comment 3 by fukino@chromium.org, Apr 27 2017

Cc: yoshiki@chromium.org fukino@chromium.org
Owner: tetsui@chromium.org
Thanks vitaliii@!
tetsui@, could you take a look?
We see something like "PathUserData (Cannot obtain size for: /b/s/w/ithqH7Ab/.org.chromium.Chromium.7lEkXH/dSKlZab)" in both file manager tests and other tests.
I guess there is an issue outside file manager...
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19c029857590d6de09de4fee67c92a9d457391c4

commit 19c029857590d6de09de4fee67c92a9d457391c4
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Apr 27 12:18:31 2017

Disable CreateNewFolder/FileManagerBrowserTest because flaky.

TBR=yoshiki@chromium.org

BUG= 715963 

Review-Url: https://codereview.chromium.org/2848613002
Cr-Commit-Position: refs/heads/master@{#467644}

[modify] https://crrev.com/19c029857590d6de09de4fee67c92a9d457391c4/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Labels: -Sheriff-Chromium
We see the same error in  issue 715961  for MultiProfileFileManagerBrowserTest.PRE_BasicDrive test.

Comment 7 by tetsui@chromium.org, Apr 28 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc4b5accdea133c4b5de50e5ae7185ef6f483e4

commit 6bc4b5accdea133c4b5de50e5ae7185ef6f483e4
Author: tetsui <tetsui@chromium.org>
Date: Thu Jun 22 02:25:14 2017

Restore disabled flaky tests of FileManager.

BUG= 715961 , 715963 
TEST=out/Release/browser_tests '--gtest_filter=*FileManagerBrowserTest*' --gtest_repeat=40

Review-Url: https://codereview.chromium.org/2911963003
Cr-Commit-Position: refs/heads/master@{#481408}

[modify] https://crrev.com/6bc4b5accdea133c4b5de50e5ae7185ef6f483e4/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 9 by tetsui@chromium.org, Jun 22 2017

Status: Fixed (was: Started)
Curious, was the cause of these flakes determined?

I'm seeing them flake in the mash_browser_tests variant, which we run on Mojo FYI bots.

I'm also seeing: "Cannot obtain size for" when running them locally.
> was the cause of these flakes determined?
I enabled the test based on the hypothesis in #3 (issue outside file manager), so didn't dig into the detail at that time. Maybe there's still a problem on the test side.

> I'm also seeing: "Cannot obtain size for" when running them locally.
Did it also flake locally? I wonder if you would give me the build options and commands.

At that time, I tried

out/Release/browser_tests '--gtest_filter=*FileManagerBrowserTest*' --gtest_repeat=40
with is_debug=false use_goma=true target_os="chromeos" is_component_build=true remove_webcore_debug_symbols=true

and it ran without any failure, so I assumed it was fixed.
Status: Assigned (was: Fixed)
Re-opening because this test is flaking due to crash on linux-chromeos-dbg. Interestingly it doesn't look flaky on linux-chromeos-rel.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=CreateNewFolder%2FFileManagerBrowserTest.Test%2F3

Stack trace:

[26610:26610:0117/074446.421588:INFO:CONSOLE(5368)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5368)
[26610:26610:0117/074446.563589:FATAL:private_api_file_system.cc(811)] Check failed: external_backend->CanHandleType(file_system_url.type()). 
#0 0x7f3ad55fea0d base::debug::StackTrace::StackTrace()
#1 0x7f3ad55fcf8c base::debug::StackTrace::StackTrace()
#2 0x7f3ad5681a9d logging::LogMessage::~LogMessage()
#3 0x000003437983 extensions::FileManagerPrivateInternalResolveIsolatedEntriesFunction::RunAsync()
#4 0x0000086961bd ChromeAsyncExtensionFunction::Run()
#5 0x000003b31894 ExtensionFunction::RunWithValidation()
#6 0x000003b37dbb extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal()
#7 0x000003b36e54 extensions::ExtensionFunctionDispatcher::Dispatch()
#8 0x000003b9ea8c extensions::ExtensionWebContentsObserver::OnRequest()
#9 0x000003ac0f22 _ZN3IPC20DispatchToMethodImplIN10extensions21AppWindowContentsImplEMS2_FvPN7content15RenderFrameHostERKNSt3__16vectorINS1_15DraggableRegionENS6_9allocatorIS8_EEEEES4_NS6_5tupleIJSB_EEEJLm0EEEEvPT_T0_PT1_OT2_NS6_16integer_sequenceImJXspT3_EEEE
#10 0x000003ac0e50 _ZN3IPC16DispatchToMethodIN10extensions21AppWindowContentsImplEN7content15RenderFrameHostEJRKNSt3__16vectorINS1_15DraggableRegionENS5_9allocatorIS7_EEEEENS5_5tupleIJSA_EEEEENS5_9enable_ifIXeqsZT1_sr3std10tuple_sizeINS5_5decayIT2_E4typeEEE5valueEvE4typeEPT_MSM_FvPT0_DpT1_ESP_OSH_
#11 0x000003b9f0f1 _ZN3IPC8MessageTI29ExtensionHostMsg_Request_MetaNSt3__15tupleIJ31ExtensionHostMsg_Request_ParamsEEEvE8DispatchIN10extensions28ExtensionWebContentsObserverES9_N7content15RenderFrameHostEMS9_FvPSB_RKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#12 0x000003b9e9fc extensions::ExtensionWebContentsObserver::OnMessageReceived()
#13 0x00000869725a extensions::ChromeExtensionWebContentsObserver::OnMessageReceived()
#14 0x7f3acdbeba69 content::WebContentsImpl::OnMessageReceived()
#15 0x7f3acd27bbd1 content::RenderFrameHostImpl::OnMessageReceived()
#16 0x7f3acd87b339 content::RenderProcessHostImpl::OnMessageReceived()
#17 0x7f3ad0eccc38 IPC::ChannelProxy::Context::OnDispatchMessage()
#18 0x7f3ad0ed2c6f _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIRK13scoped_refptrIS4_EJS7_EEEvS9_OT_DpOT0_
#19 0x7f3ad0ed2bcf _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_
#20 0x7f3ad0ed2b5d _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKNSt3__15tupleIJSC_S6_EEEJLm0ELm1EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE
#21 0x7f3ad0ed2a6c _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#22 0x7f3ad55af041 _ZNO4base12OnceCallbackIFvvEE3RunEv
#23 0x7f3ad56037d0 base::debug::TaskAnnotator::RunTask()
#24 0x7f3ad56a03fa base::internal::IncomingTaskQueue::RunTask()
#25 0x7f3ad56a890f base::MessageLoop::RunTask()
#26 0x7f3ad56a8b75 base::MessageLoop::DeferOrRunPendingTask()
#27 0x7f3ad56a8e71 base::MessageLoop::DoWork()
#28 0x7f3ad56af013 base::MessagePumpLibevent::Run()
#29 0x7f3ad56a81cc base::MessageLoop::Run()
#30 0x7f3ad575d265 base::RunLoop::Run()
#31 0x000006ae53e6 content::RunThisRunLoop()
#32 0x000006ae53ac content::RunMessageLoop()
#33 0x000002326f20 file_manager::(anonymous namespace)::FileManagerTestListener::GetNextMessage()
#34 0x000002326567 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#35 0x000002326517 file_manager::FileManagerBrowserTestBase::StartTest()
#36 0x000002342461 file_manager::GalleryBrowserTest_TraverseSlideImagesOnDownloads_Test::RunTestOnMainThread()
#37 0x000006a2cef7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#38 0x000000978f2d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIP21RenderViewContextMenuJEEEvS4_OT_DpOT0_
#39 0x000000978e74 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#40 0x000006a2f1c5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#41 0x000006a2f10c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#42 0x00000095c57d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#43 0x0000059b48e0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#44 0x0000059b2c5c ChromeBrowserMainParts::PreMainMessageLoopRun()
#45 0x000002cd7dae chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#46 0x7f3accdeb674 content::BrowserMainLoop::PreMainMessageLoopRun()
#47 0x7f3acbc22a0d _ZN4base8internal13FunctorTraitsIMN7content14NetworkContextEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#48 0x7f3acbc22954 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content14NetworkContextEFvvEJPS5_EEEvOT_DpOT0_
#49 0x7f3accdf28b5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#50 0x7f3accdf27fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#51 0x7f3acbbe7ced _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#52 0x7f3acdb687cd content::StartupTaskRunner::RunAllTasksNow()
#53 0x7f3accde69d9 content::BrowserMainLoop::CreateStartupTasks()
#54 0x7f3accdf48b6 content::BrowserMainRunnerImpl::Initialize()
#55 0x7f3accddf4d4 content::BrowserMain()
#56 0x7f3aceccf37d content::RunNamedProcessTypeMain()
#57 0x7f3acecd1d9a content::ContentMainRunnerImpl::Run()
#58 0x7f3acecc94ed content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#59 0x7f3ac866e51c service_manager::Main()
#60 0x7f3acecce2ab content::ContentMain()
#61 0x000006a2cb52 content::BrowserTestBase::SetUp()
Ah, the failing check is a DCHECK, which is likely why it never flakes on Release.
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eb6e9a6dda23ae4bb3bcebcb2dbff49329e956c

commit 5eb6e9a6dda23ae4bb3bcebcb2dbff49329e956c
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Jan 17 20:35:04 2018

Disable CreateNewFolder/FileManagerBrowserTest due to flake.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=CreateNewFolder%2FFileManagerBrowserTest.Test%2F3

Bug:  715963 
Change-Id: I3cfdbb17f0a6478a1cb36e068905cbc9313b326b

TBR=yoshiki@chromium.org,tetsui@chromium.org

Change-Id: I3cfdbb17f0a6478a1cb36e068905cbc9313b326b
Reviewed-on: https://chromium-review.googlesource.com/870752
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529862}
[modify] https://crrev.com/5eb6e9a6dda23ae4bb3bcebcb2dbff49329e956c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 15 by warx@chromium.org, Jan 22 2018

Cc: yamaguchi@chromium.org
It should be related to  issue 803505 .

Comment 16 by warx@chromium.org, Jan 22 2018

I mean same root cause there...

Comment 17 by warx@chromium.org, Jan 22 2018

More affected tests are:

GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
                  .TraverseSlideImagesOnDownloads
                  .StopStartSlideshowOnDownloads
                  .SlideshowTraversalOnDownloads
                  .OpenSingleImageOnDownloads
                  .SlideshowTraversalOnDrive
                  .TraverseSlideThumbnailsOnDownloads

AudioPlayerBrowserTest.TogglePlayState
AudioPlayerBrowserTest.ChangeVolumeLevel
VideoPlayerBrowserTest.OpenSingleVideoOnDownloads
QuickView/FileManagerBrowserTest.Test

Comment 18 by kbr@chromium.org, Apr 5 2018

Blockedon: 829310

Comment 19 by noel@chromium.org, Apr 19 2018

Cc: tetsui@chromium.org
Owner: noel@chromium.org
Status: WontFix (was: Assigned)
This test is not currently running on the bots [1].  Went we get to re-enabling this test, will address, but for now, nothing to fix WONTFIX.

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=CreateNewFolder%2FFileManagerBrowserTest.Test%2F0

Comment 20 by noel@chromium.org, Apr 22 2018

Status: Started (was: WontFix)
Actually, #12 mentioned cause fixed in  issue 829310  and related
  Check failed: external_backend->CanHandleType(file_system_url.type())

Re-open here, to land a re-enable for this test.

Comment 21 by noel@chromium.org, Apr 22 2018

Components: Platform>Apps>FileManager
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e31ffb2b6b3f3b1e2aa368fce0259ad4b2ea458

commit 4e31ffb2b6b3f3b1e2aa368fce0259ad4b2ea458
Author: Noel Gordon <noel@chromium.org>
Date: Sun Apr 22 23:47:49 2018

[ChromeOS] Re-enable CreateNewFolder/FileManagerBrowserTest

Fixed on  issue 831074   issue 804413   issue 829310 .

Tbr: smcgruer@chromium.org
Bug:  715963 
Change-Id: I7079abc4bf86413af59504199abfa1920e3276dd
Reviewed-on: https://chromium-review.googlesource.com/1023611
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552612}
[modify] https://crrev.com/4e31ffb2b6b3f3b1e2aa368fce0259ad4b2ea458/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 23 by noel@chromium.org, Apr 22 2018

Status: Fixed (was: Started)
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320e825015a688df74255de1a9f840da6a5627be

commit 320e825015a688df74255de1a9f840da6a5627be
Author: Noel Gordon <noel@chromium.org>
Date: Mon Apr 23 03:09:27 2018

[ChromeOS] Mash disable CreateNewFolder/FileManagerBrowserTest

Mash does not understand FileManageBrowserTests in general and
this test is now active on the CQ. Tell mash to ignore it.

Bug:  715963 
Change-Id: I0266057dbdc3afedf37149520758033c237d8cac
Reviewed-on: https://chromium-review.googlesource.com/1023622
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552625}
[modify] https://crrev.com/320e825015a688df74255de1a9f840da6a5627be/testing/buildbot/filters/mash.browser_tests.filter

Sign in to add a comment