New issue
Advanced search Search tips

Issue 715960 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.PostMessageTest#testMessageChannelUsingPendingPort" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 27 2017

Issue description

"org.chromium.android_webview.test.PostMessageTest#testMessageChannelUsingPendingPort" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXwsSBUZsYWtlIlRvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuUG9zdE1lc3NhZ2VUZXN0I3Rlc3RNZXNzYWdlQ2hhbm5lbFVzaW5nUGVuZGluZ1BvcnQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
In all 3 cases the error log is
=== START ===
junit.framework.ComparisonFailure: expected:<[HELLOfrom_js]> but was:<[]>
	at org.chromium.android_webview.test.PostMessageTest.testMessageChannelUsingPendingPort(PostMessageTest.java:702)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
=== END ===
I am disabling the test.
The CL is https://codereview.chromium.org/2845863004/ and it is being submitted right now.
Cc: yus...@chromium.org
Owner: sgu...@chromium.org
Status: Assigned (was: Untriaged)
Please have a look.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c186cf10dc3367044f9143308bc3452eff0cd22c

commit c186cf10dc3367044f9143308bc3452eff0cd22c
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Apr 27 14:18:14 2017

Disable PostMessageTest#testMessageChannelUsingPendingPort because flaky

Disable org.chromium.android_webview.test.PostMessageTest#testMessageCha
nnelUsingPendingPort because it is flaky.

TBR=sgurun@chromium.org

BUG= 715960 

Review-Url: https://codereview.chromium.org/2845863004
Cr-Commit-Position: refs/heads/master@{#467667}

[modify] https://crrev.com/c186cf10dc3367044f9143308bc3452eff0cd22c/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

Labels: -Sheriff-Chromium

Comment 7 by sgu...@chromium.org, Apr 27 2017

Components: Mobile>WebView
interesting. This is the second postmessage test that was marked as flaky, and these tests worked fine for more than a year. 

I wonder if some refactoring has anything to do with it. Darin's CL is the most major one I can think of.

Comment 8 by sgu...@chromium.org, Sep 15 2017

Owner: ----
Status: Available (was: Assigned)

Comment 9 by boliu@chromium.org, Sep 26 2017

looped test locally 50 times and no failures. gonna try enabling with RetryOnFailure. I guess someone check back in a couple of weeks and see if there are any flakes on the flakiness dashboard

https://chromium-review.googlesource.com/c/chromium/src/+/685281
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dacb6d43eff1948adf3f458f2a285902aac4bdc1

commit dacb6d43eff1948adf3f458f2a285902aac4bdc1
Author: Bo Liu <boliu@chromium.org>
Date: Tue Sep 26 23:24:16 2017

aw: Enable testMessageChannelUsingPendingPort with RetryOnFailure

Can't repro failure locally, so try again on bots.

Bug:  715960 
Change-Id: I9f6393799927e45c15804a8d41cdb16e0ef4da04
Reviewed-on: https://chromium-review.googlesource.com/685281
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504517}
[modify] https://crrev.com/dacb6d43eff1948adf3f458f2a285902aac4bdc1/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41147dd6d6eb10938fb002f546ad94bcb702b233

commit 41147dd6d6eb10938fb002f546ad94bcb702b233
Author: Bo Liu <boliu@chromium.org>
Date: Sun Oct 01 03:58:14 2017

aw: Remove RetryOnFailure for testMessageChannelUsingPendingPort

Looks good on cq for 3 days.

Bug:  715960 
Change-Id: I40905c5ddcb7cbb1797906ace7126a52d20c33a8
Reviewed-on: https://chromium-review.googlesource.com/693416
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505497}
[modify] https://crrev.com/41147dd6d6eb10938fb002f546ad94bcb702b233/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

Status: Fixed (was: Available)

Sign in to add a comment