New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715951 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Use other robhogan account instead.
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8% regression in memory.top_10_mobile at 466539:466553

Project Member Reported by rmcilroy@chromium.org, Apr 27 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 27 2017

Cc: robho...@gmail.com
Owner: robho...@gmail.com

=== Auto-CCing suspected CL author robhogan@gmail.com ===

Hi robhogan@gmail.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : robhogan
  Commit : fe767186a3dc40ea14b5f807ff5438bd78f79c95
  Date   : Sat Apr 22 19:24:41 2017
  Subject: Use a non-replaced inline container for image alt text

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/background/after_http_search_yahoo_com_search__ylt_p_google
  Change       : 1.83% | 112596.0 -> 114652.0

Revision             Result             N
chromium@466538      112596 +- 0.0      6      good
chromium@466542      112596 +- 0.0      6      good
chromium@466544      112596 +- 0.0      6      good
chromium@466545      112596 +- 0.0      6      good
chromium@466546      114652 +- 0.0      6      bad       <--
chromium@466553      114652 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981168762259406592

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5043243919605760


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: -robho...@gmail.com robhogan@chromium.org
Owner: rob.buis@chromium.org
rmcilroy - is this a 'real' regression do you think? I don't think I've introduced any leaks or anything - maybe we're just displaying the broken image icon more often in these pages? The broken images are probably a function of the way the page is stored for testing rather than the pages themselves maybe?
Owner: robhogan@chromium.org
robhogan - I'm not sure, it's a pretty big CL so there might be unintended side-effects. It should be easy enough to check by running the test locally and seeing if there are any unexpected broken images which wouldn't appear on the real site (comment 3 has repo instructions).

Comment 7 by robho...@gmail.com, May 11 2017

It's actually quite a small CL code-wise, just HTMLImageFallBackHelper.cpp: the rest is test infra.

Had a go at recreating this regression but could not get it running on my phone. :/
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.

Comment 9 by robho...@gmail.com, Jul 29 2017

Status: Fixed (was: Assigned)
Closing this per comment #4 and #7 - there's no leak here, we must be displaying more broken image icons due to the way the page is stored for testing.

Comment 10 by robho...@gmail.com, Jul 29 2017

Status: WontFix (was: Fixed)

Sign in to add a comment