New issue
Advanced search Search tips

Issue 715946 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Browser shouldn't request ThemeService in upgrade_util::SwapNewChromeExeIfPresent

Project Member Reported by se...@yandex-team.ru, Apr 27 2017

Issue description

Browser can request for ThemeService at update/shutdown phase. It would be nice to fix this.
Initially it was found here: bug 715727.

https://crash.corp.google.com/browse?q=ReportID%3D%27d5a50d5640000000%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=&index=0

Thread 0 CRASHED [EXCEPTION_ACCESS_VIOLATION_EXEC @ 0x687ff8ba ] MAGIC SIGNATURE THREAD
0x687ff8ba		
0x6d5eaeca	(chrome.dll -browser_context_keyed_service_factory.cc:103 )	BrowserContextKeyedServiceFactory::GetContextToUse(base::SupportsUserData *)
0x6d336875	(chrome.dll -keyed_service_factory.cc:63 )	KeyedServiceFactory::GetServiceForContext(base::SupportsUserData *,bool)
0x6d91a569	(chrome.dll -theme_service_factory.cc:28 )	ThemeServiceFactory::GetForProfile(Profile *)
0x6d926b7d	(chrome.dll -theme_service.cc:408 )	ThemeService::GetThemeProviderForProfile(Profile *)
0x6d7bb772	(chrome.dll -browser_desktop_window_tree_host_win.cc:231 )	BrowserDesktopWindowTreeHostWin::GetFrameMode()
0x6d9c617d	(chrome.dll -hwnd_message_handler.cc:1276 )	views::HWNDMessageHandler::IsFrameSystemDrawn()
0x6d9c6d78	(chrome.dll -hwnd_message_handler.cc:1885 )	views::HWNDMessageHandler::OnNCPaint(HRGN__ *)
0x6d9c444e	(chrome.dll -hwnd_message_handler.h:416 )	views::HWNDMessageHandler::_ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long)
0x6d9c5771	(chrome.dll -hwnd_message_handler.cc:914 )	views::HWNDMessageHandler::OnWndProc(unsigned int,unsigned int,long)
0x6ce425ad	(chrome.dll -window_impl.cc:303 )	gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)
0x6ce42614	(chrome.dll -wrapped_window_proc.h:76 )	base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)>(HWND__ *,unsigned int,unsigned int,long)
0x775f62f9	(USER32.dll + 0x000162f9 )	InternalCallWinProc
0x775f7315	(USER32.dll + 0x00017315 )	NtUserGetDC
0x775f6de7	(USER32.dll + 0x00016de7 )	DispatchClientMessage
0x775f6e43	(USER32.dll + 0x00016e43 )	__fnDWORD
0x77b70119	(ntdll.dll + 0x00010119 )	KiUserCallbackDispatcher
0x77b7007f	(ntdll.dll + 0x0001007f )	KiUserApcDispatcher
0x775f6a8b	(USER32.dll + 0x00016a8b )	RealDefWindowProcW
0x775f6ae8	(USER32.dll + 0x00016ae8 )	DefWindowProcW
0x6d9c57aa	(chrome.dll -hwnd_message_handler.cc:920 )	views::HWNDMessageHandler::OnWndProc(unsigned int,unsigned int,long)
0x6ce425ad	(chrome.dll -window_impl.cc:303 )	gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)
0x6ce42614	(chrome.dll -wrapped_window_proc.h:76 )	base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned int,long)>(HWND__ *,unsigned int,unsigned int,long)
0x775f62f9	(USER32.dll + 0x000162f9 )	InternalCallWinProc
0x775f6d39	(USER32.dll + 0x00016d39 )	UserCallWinProcCheckWow
0x775f6de7	(USER32.dll + 0x00016de7 )	DispatchClientMessage
0x775f6e43	(USER32.dll + 0x00016e43 )	__fnDWORD
0x77b70119	(ntdll.dll + 0x00010119 )	KiUserCallbackDispatcher
0x77b7007f	(ntdll.dll + 0x0001007f )	KiUserApcDispatcher
0x77600750	(USER32.dll + 0x00020750 )	NtUserPeekMessage
0x772bcf6f	(ole32.dll + 0x0001cf6f )	CCliModalLoop::MyPeekMessage(tagMSG *,HWND__ *,unsigned int,unsigned int,unsigned short)
0x772bcfe4	(ole32.dll + 0x0001cfe4 )	CCliModalLoop::PeekRPCAndDDEMessage()
0x772bd22b	(ole32.dll + 0x0001d22b )	CCliModalLoop::BlockFn(void * *,unsigned long,unsigned long *)
0x772c2d30	(ole32.dll + 0x00022d30 )	ModalLoop(CMessageCall *)
0x773dd2f5	(ole32.dll + 0x0013d2f5 )	CStdAsyncStubBuffer_QueryInterface
0x773dd097	(ole32.dll + 0x0013d097 )	CStdProxyBuffer_QueryInterface
0x773dceef	(ole32.dll + 0x0013ceef )	
0x772c2cb9	(ole32.dll + 0x00022cb9 )	CCliModalLoop::SendReceive(tagRPCOLEMESSAGE *,unsigned long *,IInternalChannelBuffer *)
0x772d9aa0	(ole32.dll + 0x00039aa0 )	CAptRpcChnl::SendReceive(tagRPCOLEMESSAGE *,unsigned long *)
0x772d9b23	(ole32.dll + 0x00039b23 )	CCtxComChnl::SendReceive(tagRPCOLEMESSAGE *,unsigned long *)
0x773dce05	(ole32.dll + 0x0013ce05 )	
0x76cc414a	(RPCRT4.dll + 0x0003414a )	NdrpProxySendReceive
0x76d40148	(RPCRT4.dll + 0x000b0148 )	NdrClientCall2
0x773dc8e1	(ole32.dll + 0x0013c8e1 )	CRpcChannelBuffer::ClientGetBuffer
0x772d98ac	(ole32.dll -stubless.asm:142 )	ObjectStubless
0x772db640	(ole32.dll + 0x0003b640 )	RemoteReleaseRifRefHelper(IRemUnknown *,int,int,OXIDEntry *,unsigned short,tagREMINTERFACEREF *,IUnknown *)
0x772db5ec	(ole32.dll + 0x0003b5ec )	RemoteReleaseRifRef(CStdMarshal *,OXIDEntry *,unsigned short,tagREMINTERFACEREF *)
0x772db171	(ole32.dll + 0x0003b171 )	CStdMarshal::DisconnectCliIPIDs()
0x772da66d	(ole32.dll + 0x0003a66d )	CStdMarshal::Disconnect(unsigned long)
0x772da816	(ole32.dll + 0x0003a816 )	CStdIdentity::~CStdIdentity()
0x772da780	(ole32.dll + 0x0003a780 )	CStdIdentity::`scalar deleting destructor'(unsigned int)
0x772daaf2	(ole32.dll + 0x0003aaf2 )	CStdIdentity::CInternalUnk::Release()
0x773036aa	(ole32.dll -aggid.cxx:71 )	CAggId::~CAggId()
0x77303662	(ole32.dll + 0x00063662 )	CAggId::`scalar deleting destructor'(unsigned int)
0x7730364b	(ole32.dll + 0x0006364b )	CAggId::Release()
0x773dd37f	(ole32.dll + 0x0013d37f )	
0x6d903ffa	(chrome.dll -upgrade_util_win.cc:73 )	`anonymous namespace'::InvokeGoogleUpdateForRename
0x6d9041ee	(chrome.dll -upgrade_util_win.cc:114 )	upgrade_util::SwapNewChromeExeIfPresent()
0x6cab0bc2	(chrome.dll -browser_shutdown.cc:225 )	browser_shutdown::ShutdownPostThreadsStop(int)
0x6ca9ccb3	(chrome.dll -chrome_browser_main.cc:2060 )	ChromeBrowserMainParts::PostDestroyThreads()
0x6c701267	(chrome.dll -browser_main_loop.cc:1385 )	content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
0x6c703506	(chrome.dll -browser_main_runner.cc:200 )	content::BrowserMainRunnerImpl::Shutdown()
0x6c6fe39a	(chrome.dll -browser_main.cc:48 )	content::BrowserMain(content::MainFunctionParams const &)
0x6ca65777	(chrome.dll -content_main_runner.cc:729 )	content::ContentMainRunnerImpl::Run()
0x6d2f1f4b	(chrome.dll -main.cc:179 )	service_manager::Main(service_manager::MainParams const &)
0x6c4edadc	(chrome.dll -chrome_main.cc:123 )	ChromeMain
0x01195978	(chrome.exe -main_dll_loader_win.cc:202 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x011921a2	(chrome.exe -chrome_exe_main_win.cc:271 )	wWinMain
0x012034c7	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x774a33c9	(kernel32.dll + 0x000133c9 )	BaseThreadInitThunk
0x77b99ed1	(ntdll.dll + 0x00039ed1 )	__RtlUserThreadStart
0x77b99ea4	(ntdll.dll + 0x00039ea4 )	_RtlUserThreadStart
 
Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
unable to check the crash data using the link provided in bug report

https://crash.corp.google.com/browse?q=ReportID%3D%27d5a50d5640000000%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=&index=0 and looks llike WIP in bug 715727.

***UI Mass Triage***

Since work is in progress, adding appropriate labels.

Sign in to add a comment