Issue metadata
Sign in to add a comment
|
Unnecessary blue focus ring overlap with ‘h’ of https of any website url.
Reported by
abom...@etouch.net,
Apr 27 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3082.0 (Official Build) (190ee07cecf53e3795197cc195b844f7cc15a9ea-refs/heads/master@{#467534} OS: Mac (10.12.1,10.11.6) What steps will reproduce the problem? 1. Launch chrome and navigate to any website (https://permission.site/) 2. Click on Omnibox and press ‘Shift +Tab’ ,Observe. Actual: Unnecessary blue focus ring overlap with ‘h’ of https. Expected: Focus ring should not overlap. This is non regression issue, seen from ‘M 60’ (60.0.3082.0) as it is newly added feature. Note: Issue is not seen on Windows and Linux OS.
,
Apr 27 2017
,
Apr 27 2017
Hmm, that's tricky. A smaller region would not be symmetric for non-verbose states. CCing ellyjones@, who was involved with getting the security indicator in the desktop tab order, last I heard.
,
Apr 28 2017
Hm. macOS focus rings are supposed to look external to the control like that, so the look of the focus ring itself is WAI, but it being too close to the schema is not. The controls are simply too close together for the focus ring to work properly with the verbose indicator. I'll try having the verbose indicator draw its focus ring closer to its visual bounds instead of its real bounds and see if that helps.
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0f29cf86073f026098badc2dfe6ee7a7520b65 commit 7d0f29cf86073f026098badc2dfe6ee7a7520b65 Author: ellyjones <ellyjones@chromium.org> Date: Fri Apr 28 19:39:38 2017 cocoa: don't draw focus rings over the URL scheme in the location bar The security state decoration looks like this: Secure | The divider is included in the bounds, and then the location bar text is placed just after this decoration; because of that, the focus ring on the security state decoration (which is exterior to the decoration, like Cocoa focus rings usually are) draws over the top of the start of the location bar text. This change: 1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each decoration to control its focus ring bounds if it needs to 2) Overrides that method in SecurityStateBubbleDecoration to inset the focus ring on the right side BUG= 715909 Review-Url: https://codereview.chromium.org/2847903003 Cr-Commit-Position: refs/heads/master@{#468096} [modify] https://crrev.com/7d0f29cf86073f026098badc2dfe6ee7a7520b65/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h [modify] https://crrev.com/7d0f29cf86073f026098badc2dfe6ee7a7520b65/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm [modify] https://crrev.com/7d0f29cf86073f026098badc2dfe6ee7a7520b65/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h [modify] https://crrev.com/7d0f29cf86073f026098badc2dfe6ee7a7520b65/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
,
May 1 2017
Fixed?
,
May 1 2017
Yep, thanks :)
,
May 4 2017
Tested the issue on Mac-10.12.4 using chrome version# 60.0.3088.3 with the below steps. 1. Launch chrome and navigated to website (https://permission.site/) 2. Clicked on Omnibox and press ‘Shift +Tab’ . Not observed the focus on Secure icon. Could you please confirm, is it the expected behavior? Please find the attached screen cast for reference. Thanks.
,
May 4 2017
,
May 4 2017
#8: Did you turn on Full Keyboard Access? Apple > System Preferences > Keyboard > Shortcuts > Full Keyboard Access
,
May 5 2017
Verified the issue on Mac-10.12.4 using chrome version# 60.0.3088.3 with the steps mentioned in comment#0 and comment#10. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screencast for the same. Thanks..
,
May 25 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Apr 27 2017