New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715906 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 635633



Sign in to add a comment

Regression: Unnecessary 'x' icon is seen without typing any keyword is text field at Add language overlay

Reported by sans...@etouch.net, Apr 27 2017

Issue description

Chrome Version: 60.0.3082.0 (Official Build)190ee07cecf53e3795197cc195b844f7cc15a9ea-refs/heads/master@{#467534}-32/64 bit
OS: Windows (7,8,8.1,10)

Steps:
1. Launch Chrome and navigate to chrome://settings,click on Advanced
2. Go to Language section, click on Add languages and observe

Actual: Unnecessary 'x' icon is seen without typing any keyword is text field

Expected: 'x' icon should not be seen without typing anything is text field


This is a regression issue broken in M-60, will soon update the bisect and other OS info 

Good build: 60.0.3081.0
Bad build: 60.0.3082.0




 
Actual_result.jpg
95.9 KB View Download
Expected_result.jpg
98.9 KB View Download

Comment 1 by sans...@etouch.net, Apr 27 2017

Labels: OS-Linux OS-Mac
Above issue is also seen on Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)
Cc: sureshkumari@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Bisect:
--------------
Good build:60.0.3081.0-(Revision-467177)
Bad build: 60.0.3082.0-(Revision-467534)
Per revision bisect Tool Info:
------------------------------
https://chromium.googlesource.com/chromium/src/+log/efd8268f95f1c7a212e5b6edd521761dd8a00e31..60869ccf490d8a71bdbe64bca909b80b0348d805

Review-Url: https://codereview.chromium.org/2840713002
dpapad@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thanks.!

Comment 3 by dpa...@chromium.org, Apr 27 2017

Blocking: 635633
Labels: Proj-MaterialDesign-WebUI

Comment 4 by dpa...@chromium.org, Apr 27 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8390124cd5b4d6b0101a18ec2ad785cf64baa0fe

commit 8390124cd5b4d6b0101a18ec2ad785cf64baa0fe
Author: dpapad <dpapad@chromium.org>
Date: Fri Apr 28 02:55:08 2017

MD Settings: Add missing cr-hidden-style in settings_subpage_search.html.

BUG= 715906 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846103003
Cr-Commit-Position: refs/heads/master@{#467856}

[modify] https://crrev.com/8390124cd5b4d6b0101a18ec2ad785cf64baa0fe/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Comment 6 by dpa...@chromium.org, Apr 28 2017

Status: Fixed (was: Started)
Labels: TE-Verified-M60 TE-Verified-60.0.3088.3
Tested the issue on Windows-7, Mac-10.12.4 and Linux Ubuntu-14.04 using chrome version# 60.0.3088.3 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
715906.mp4
227 KB View Download

Sign in to add a comment