The Page Info button string should match the title of what it's linking to |
|||
Issue descriptionChrome Version: 60.0.3080.0 OS: Desktop Chrome What steps will reproduce the problem? (1) Navigate to https://www.google.com. (2) Open the Page Info bubble by clicking the Security Origin Chip in the Omnibox. (3) Click "Site settings" at the bottom of the bubble. (4) Observe that a new tab with MD settings opens to a section titled "Content Settings". What is the expected result? The string on the button at the bottom of the Page Info bubble matches the title of the settings it is linking to, i.e. the Page Info button should say "Content settings" instead of "Site settings". What happens instead? The string doesn't match, so it's confusing that "Site settings" links to a place called "Content Settings".
,
Apr 27 2017
lgarron@: this bug is about doing the reverse; making the button in the page info bubble say "Content settings". that section in settings was named "Site settings" for a while, but that was while there were actually ... site-organized permissions. there aren't yet (unless you flip --enable-site-settings). they're still "Content settings" because they're organized by content-type (i.e. Cookies). this helps users that upgrade from old to new (MD) understand they're the same more easily. patricialor@: there's conditional logic in the title of the page in settings (to choose between Content and Site Settings), can we copy this to page info bubble?
,
Apr 27 2017
"Site settings" will eventually be reflected in chrome://settings, right? The string in Page Info is deliberate for the interim, and we want users to understand "sites" – "content" is pretty generic. Is there a compelling reason for changing this right now, when we've intentionally used that string for 2 years? Have you talked to UI review about it?
,
Apr 28 2017
Oh, I didn't realise the string intentionally didn't match. This came up because I thought the button string should be updated to say "Site details" when we change the link to point there instead of "Content Settings", and dbeam@ said either way, this should be changed regardless of the state of "Site Details", since it currently doesn't match already. If it's intentional, I can change the bug desc to just refer to updating the string to Site Details when the linking change happens. (In case it wasn't clear, I haven't talked to UI review about it, so I'm happy to leave it as is. Thanks for clarifying!)
,
Jun 26 2017
Closing this since it looks like the "Site settings" button string is intentionally different. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lgar...@chromium.org
, Apr 27 2017