Issue metadata
Sign in to add a comment
|
Decoupling focus and selection causes regressions |
||||||||||||||||||||||
Issue descriptionThis issue is a meta bug for regression caused by patch[1]. Since patch[1] improves compatibility among the browsers, and these regressions depend on buggy behavior fixed by patch[1]. We would like to try workaround of them or asking page owners to change not to depend on buggy behavior. As of today following issues report regression: - Issue 712094 Regression:Add language navigates to the top after selecting language - Issue 712986 Broken autoscroll when focusing hidden selection - Issue 713051 Blink should not accept key stroke and blink caret when selection doesn't have focus - Issue 713607 Regression: [MD Settings] Unable to scroll the Settings page using up/down arrow key - Issue 714000 Regression: Unnecessary blue line appears on person name textbox on clicking any Avatar icon - Issue 714525 Regression: Cursor pin remains stuck at 'Enter custom web address' field even after tap/touch on New Tab page - Issue 714535 Regression:Auto-scroll of page after removing words in manage spell check of md-settings - Issue 715036 Regression: Cursor is missing on Add Address overlay text fields. - Issue 715038 Regression : Focus issue is seen on chrome://history/ page - Issue 715059 Wrong context menu after hiding selection - Issue 715353 MD Settings: Enter is ignored inside /networks?type=WiFi (ChromeOS) [1] http://crrev.com/2616623002: Do not send redundant selectionchange-events (decouple focus)
,
Apr 27 2017
,
May 2 2017
,
May 5 2017
,
May 8 2017
,
May 8 2017
,
May 8 2017
,
May 10 2017
Once patch[1] is land, we can fix these bugs by checking whether selection has focus or not by using FrameSelection::HasFocus(). [1] http://crrev.com/2841093002: Algorithm for deciding if a frame's selection should be hidden
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8549ed4eaf9d95db494bd7028bf17110b26b6918 commit 8549ed4eaf9d95db494bd7028bf17110b26b6918 Author: hugoh <hugoh@opera.com> Date: Thu May 11 05:28:29 2017 Algorithm for deciding if a frame's selection should be hidden Background: Crrev.com/464698 introduced "hiding" of unfocused selections in text controls. Hiding avoids clearing the selection upon change of focus. Problem: Now we only hide selections inside text controls. Selections within content-editable elements must also be hidden. Solution: Generalize previous work into an algorithm that, given current DOM and its activeElement, determines whether a frame's selection should be hidden. See the algorithm in InHidden() for documentation and read its unit tests in FrameSelectionTest.cpp. BUG= 715059 , 715889 Review-Url: https://codereview.chromium.org/2841093002 Cr-Commit-Position: refs/heads/master@{#470822} [modify] https://crrev.com/8549ed4eaf9d95db494bd7028bf17110b26b6918/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/8549ed4eaf9d95db494bd7028bf17110b26b6918/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/8549ed4eaf9d95db494bd7028bf17110b26b6918/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/8549ed4eaf9d95db494bd7028bf17110b26b6918/third_party/WebKit/Source/core/editing/LayoutSelection.cpp [modify] https://crrev.com/8549ed4eaf9d95db494bd7028bf17110b26b6918/third_party/WebKit/Source/core/editing/LayoutSelection.h
,
May 16 2017
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/582a4088398728aa9b1ab672dd92ecc9b9d589db commit 582a4088398728aa9b1ab672dd92ecc9b9d589db Author: hugoh <hugoh@opera.com> Date: Tue May 16 16:35:59 2017 Rename *Focus*-methods of FrameSelection to clarify its public API As we've now added FS::SelectionHasFocus in [1], let's rename FS::*IsFocused* to FS::*FrameIsFocused* to emphasize that these methods give information about the Frame (in contrast to FS::SelectionHasFocus). BUG= 715889 TEST=No behavior change [1] = crrev.com/2841093002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2876973003 Cr-Commit-Position: refs/heads/master@{#472129} [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/page/FocusController.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/core/paint/ImagePainter.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/582a4088398728aa9b1ab672dd92ecc9b9d589db/third_party/WebKit/Source/web/WebViewImpl.cpp
,
May 16 2017
,
May 19 2017
yosin@ is a virtual owner.
,
May 19 2017
,
May 19 2017
,
May 23 2017
,
May 23 2017
,
May 23 2017
,
May 23 2017
,
May 24 2017
It seems all issues related to decoupling focus and selection are fixed.
,
Jun 22 2017
,
Jul 7 2017
,
Jul 20 2017
,
Sep 29 2017
,
Sep 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yosin@chromium.org
, Apr 27 2017