Determine why DaydreamApi calls silently fail |
||||
Issue descriptionAs per comments here: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java?sq=package:chromium&dr=CSs&l=23 We need to recreate the DaydreamApi each use or API calls begin to silently fail. This is unfortunate; we should find out why this is happening and fix if possible.
,
Jan 10 2018
I think this issue has been inadvertently fixed at some point in the past. CL incoming.
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5 commit b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jan 11 01:50:33 2018 VR: Cache DaydreamApi instance. A long time ago we ran into an issue where the DaydreamApi seemed to silently stop working unless we recreated it each time before using it. I can no longer reproduce this. My best guess as to the cause is that I think at the time we weren't properly recreating the DaydreamApi instance when switching between Activities, so it was associated with a wrong or leaked context. If things in VR start flakily breaking, this is a good candidate to revert. Bug: 715871 Change-Id: Iaf8c31e6d99079134b2893fae14222096e203fe6 Reviewed-on: https://chromium-review.googlesource.com/861062 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#528528} [modify] https://crrev.com/b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java [modify] https://crrev.com/b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java [modify] https://crrev.com/b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/b1e26c25b6592ee5ac0617b1dd9df0daa580a8b5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java
,
Jan 11 2018
Didn't find out why it was happening, but oh well. I think the issue's gone.
,
Feb 8 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ddorwin@chromium.org
, Apr 27 2017Labels: VR-TD Proj-VR-Daydream OS-Android