New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715870 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Typo in Cryptohome.DircryptoMigrationEndStatus histogram definition

Project Member Reported by dspaid@chromium.org, Apr 27 2017

Issue description

Should use enum DircryptoMigrationEndStatus, but it currently has DircryptoMigrationStartStatus
 

Comment 1 by uekawa@google.com, Apr 27 2017

how does that thing work, does the change in ToT just get used or do we still need cherry pick?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a005bf30441ddefd842a48dd841a532e71af9c4e

commit a005bf30441ddefd842a48dd841a532e71af9c4e
Author: dspaid <dspaid@chromium.org>
Date: Fri Apr 28 02:18:36 2017

Correct typo in Cryptohome Migration Enum

Cryptohome.DircryptoMigrationEndStatus histogram should use the
DircryptoMigrationEndStatus, not DircryptoMigrationStartStatus.

BUG= 715870 
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2848463002
Cr-Commit-Position: refs/heads/master@{#467847}

[modify] https://crrev.com/a005bf30441ddefd842a48dd841a532e71af9c4e/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 1 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/354098b98cd0111d1289fdb9a986c5d416b006f7

commit 354098b98cd0111d1289fdb9a986c5d416b006f7
Author: dspaid <dspaid@chromium.org>
Date: Mon May 01 04:33:19 2017

Correct typo in Cryptohome Migration Enum

Cryptohome.DircryptoMigrationEndStatus histogram should use the
DircryptoMigrationEndStatus, not DircryptoMigrationStartStatus.

BUG= 715870 
TEST=./validate_format.py && ./pretty_print.py
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2848463002
Cr-Commit-Position: refs/heads/master@{#467847}
(cherry picked from commit a005bf30441ddefd842a48dd841a532e71af9c4e)

Review-Url: https://codereview.chromium.org/2853733002
Cr-Commit-Position: refs/branch-heads/3071@{#315}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/354098b98cd0111d1289fdb9a986c5d416b006f7/tools/metrics/histograms/histograms.xml

Comment 6 by uekawa@google.com, May 7 2017

Status: Fixed (was: Started)
uma stats look more sane now.
Status: Verified (was: Fixed)

Sign in to add a comment