"Did you mean to go to..." infobar can truncate too much |
||||||
Issue descriptionChrome 60.0.3080.5 OSX 10.12.4 What steps will reproduce the problem? (1) Run a local server at badssl.test (and point /etc/hosts at it) (2) In a small window, enter "badssl.test" into the omnibox. What is the expected result? An infobar shows up with "Did you mean to go to http://badssl.test/?" What happens instead? The infobar shows "Did you mean to go to http://", even if there is plenty of space for the domain. (See screenshot.) Perhaps there's too much padding on the right of the bar (for a button that doesn't exist)?
,
Apr 28 2017
explicitly to shrike@ to triage, as I don't know who owns this code
,
Apr 28 2017
tapted@ - can you take a look?
,
May 1 2017
Can you give more detailed repro instructions? I can't get that infobar to pop up on demand, and ChromeOmniboxNavigationObserver has no tests that I can find. This might be an autolayout thing. Is this a regression? I suspect this - https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm [AlternateNavInfoBarDelegate addAdditionalControls] calls [self removeButtons] which does - (void)removeButtons { // Extend the label all the way across. NSRect labelFrame = [label_.get() frame]; labelFrame.size.width = NSMaxX([cancelButton_ frame]) - NSMinX(labelFrame); this relies on a layout of cancelButton_, but addAdditionalControls is called from awakeFromNib before autoresizing masks are set up.
,
May 1 2017
Auto Layout is still turned off. I can look at it eventually, but have a bunch of other things on my plate right now.
,
Mar 19 2018
,
Mar 19 2018
FYI, an update/correction to comment #4: ChromeOmniboxNavigationObserver now has tests.
,
Nov 23
*** UI Mass triage *** adding labels for expert review. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mpear...@chromium.org
, Apr 28 2017Components: -UI>Browser>Omnibox -UI>Browser>Navigation
Labels: OS-Mac