New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715866 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 0
Type: Bug



Sign in to add a comment

MD-Settings - Password not being shown

Project Member Reported by hcarmona@chromium.org, Apr 27 2017

Issue description

Steps to Reproduce:

1. Save a password
2. Go to chrome://md-settings/passwords
3. Click on a password's details
4. Click on the 'Show password' button

Expected:
Plain text password will be shown

Actual:
Password not shown :-(

Bisect range: https://chromium.googlesource.com/chromium/src/+log/cda13a9e3a043b37ecc7f28a60333091a80bdf3e..e52938b242948527f56802eb6871cdc65f7a10d7

Suspecting http://crrev.com/2651663003

 
In:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js?rcl=c54fcea42957f1effa94fedcb2d985f11488888c&l=147

There's a mismatch between the origin in the reply and the origin in the login pair.

reply.loginPair.urls.origin = 'localhost'
loginPair.urls.origin = 'localhost/'

Not sure where the '/' is coming from, but the mismatch means we don't match the password to the item we're showing.
Cc: hcarmona@chromium.org
Cc: sureshkumari@chromium.org msrchandra@chromium.org ranjitkan@chromium.org jdoerrie@chromium.org nyerramilli@chromium.org
 Issue 715894  has been merged into this issue.
Status: Started (was: Assigned)
Thank you Hector for already looking into this. I am pretty sure about the root cause and will send out a CL shortly. Sorry that this slipped during the development of r466661 :/
Fix is in http://crrev.com/2844963003.
Labels: OS-Chrome OS-Mac OS-Windows
Components: UI>Settings UI>Browser>Passwords
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2017

Comment 9 by dbeam@chromium.org, Apr 28 2017

Owner: dbeam@chromium.org
Status: Fixed (was: Started)

Comment 10 by dbeam@chromium.org, Apr 29 2017

Labels: Merge-Request-59
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b0d321f91799deaee17f021aac62967c4249d03

commit 6b0d321f91799deaee17f021aac62967c4249d03
Author: Dan Beam <dbeam@chromium.org>
Date: Mon May 01 19:01:55 2017

MD Settings: mergeable "View password" button fix

R=hcarmona@chromium.org
BUG= 715866 

Review-Url: https://codereview.chromium.org/2848983002
Cr-Commit-Position: refs/heads/master@{#468171}
(cherry picked from commit 11b44dd3ae59e1116acc9358a1807ccdf29a1359)

Review-Url: https://codereview.chromium.org/2853063003 .
Cr-Commit-Position: refs/branch-heads/3071@{#332}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/6b0d321f91799deaee17f021aac62967c4249d03/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Cc: vabr@chromium.org melandory@chromium.org
 Issue 716485  has been merged into this issue.
Labels: Hotlist-ConOps
Labels: TE-Verified-M59 TE-Verified-59.0.3071.36
Verified this issue on Mac OS 10.12.4, Windows-10 and Ubuntu 14.04 using chrome latest beta M59-59.0.3071.36 by following steps mentioned in the original comment. Observed able to view the password by clicking on show password button under chrome://md-settings. Hence adding TE-Verified label.

Thanks! 
Screen Shot 2017-05-03 at 1.09.41 PM.png
192 KB View Download
Thanks! I've updated to Canary 60.0.3088.0 and see the fix is also in there as well. I've let the users know on the Chrome forum that they should keep an eye out for the latest patch for Beta to see the fix. 
Screen Shot 2017-05-03 at 7.54.20 AM.png
23.7 KB View Download
Cc: groby@chromium.org dbeam@chromium.org shrike@chromium.org
 Issue 718209  has been merged into this issue.
Status: Verified (was: Fixed)
Verified on ChromeOS  9460.30.0, 59.0.3071.41
Cc: -vabr@chromium.org

Sign in to add a comment