MD-Settings - Password not being shown |
|||||||||||||||
Issue descriptionSteps to Reproduce: 1. Save a password 2. Go to chrome://md-settings/passwords 3. Click on a password's details 4. Click on the 'Show password' button Expected: Plain text password will be shown Actual: Password not shown :-( Bisect range: https://chromium.googlesource.com/chromium/src/+log/cda13a9e3a043b37ecc7f28a60333091a80bdf3e..e52938b242948527f56802eb6871cdc65f7a10d7 Suspecting http://crrev.com/2651663003
,
Apr 27 2017
,
Apr 27 2017
Issue 715894 has been merged into this issue.
,
Apr 27 2017
Thank you Hector for already looking into this. I am pretty sure about the root cause and will send out a CL shortly. Sorry that this slipped during the development of r466661 :/
,
Apr 27 2017
Fix is in http://crrev.com/2844963003.
,
Apr 28 2017
,
Apr 28 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11b44dd3ae59e1116acc9358a1807ccdf29a1359 commit 11b44dd3ae59e1116acc9358a1807ccdf29a1359 Author: dbeam <dbeam@chromium.org> Date: Fri Apr 28 23:08:46 2017 MD Settings: mergeable "View password" button fix R=hcarmona@chromium.org BUG= 715866 Review-Url: https://codereview.chromium.org/2848983002 Cr-Commit-Position: refs/heads/master@{#468171} [modify] https://crrev.com/11b44dd3ae59e1116acc9358a1807ccdf29a1359/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
,
Apr 28 2017
,
Apr 29 2017
,
Apr 29 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b0d321f91799deaee17f021aac62967c4249d03 commit 6b0d321f91799deaee17f021aac62967c4249d03 Author: Dan Beam <dbeam@chromium.org> Date: Mon May 01 19:01:55 2017 MD Settings: mergeable "View password" button fix R=hcarmona@chromium.org BUG= 715866 Review-Url: https://codereview.chromium.org/2848983002 Cr-Commit-Position: refs/heads/master@{#468171} (cherry picked from commit 11b44dd3ae59e1116acc9358a1807ccdf29a1359) Review-Url: https://codereview.chromium.org/2853063003 . Cr-Commit-Position: refs/branch-heads/3071@{#332} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/6b0d321f91799deaee17f021aac62967c4249d03/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
,
May 2 2017
,
May 2 2017
,
May 3 2017
Verified this issue on Mac OS 10.12.4, Windows-10 and Ubuntu 14.04 using chrome latest beta M59-59.0.3071.36 by following steps mentioned in the original comment. Observed able to view the password by clicking on show password button under chrome://md-settings. Hence adding TE-Verified label. Thanks!
,
May 3 2017
Thanks! I've updated to Canary 60.0.3088.0 and see the fix is also in there as well. I've let the users know on the Chrome forum that they should keep an eye out for the latest patch for Beta to see the fix.
,
May 3 2017
Issue 718209 has been merged into this issue.
,
May 8 2017
Verified on ChromeOS 9460.30.0, 59.0.3071.41
,
Nov 29
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by hcarmona@chromium.org
, Apr 27 2017