New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715851 link

Starred by 2 users
Status: Verified
Owner:
wzang@chromium.org
Closed: May 2017
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
alemate@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

New powerwash UI needs polish

Project Member Reported by wzang@chromium.org, Apr 27 2017 
Chrome Version: 60.0.3082.0/9460.1.0 dev-channel 
OS: Chrome

What steps will reproduce the problem?
At login screen, press Ctrl+Alt+Shift+R

The top left icon should be blue and the illustration should not be scratched (i.e. it looks a bit different from the original assets).
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/809f8b04b5b9e6242bbf7bb8e772def30d538230

commit 809f8b04b5b9e6242bbf7bb8e772def30d538230
Author: wzang <wzang@chromium.org>
Date: Thu May 04 01:40:45 2017

Powerwash UI polish

1. Change popup overlay according to new specs.
2. Change the reset alert icon
3. Other miscellaneous changes (Put powerwash texts in one line etc.)

BUG= 715851 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847603002
Cr-Commit-Position: refs/heads/master@{#469242}

[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_reset.css
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_reset.html
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.css
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.html
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/chrome/browser/resources/chromeos/login/oobe_text_button.css
[modify] https://crrev.com/809f8b04b5b9e6242bbf7bb8e772def30d538230/ui/login/screen_container.css

Comment 2 by wzang@chromium.org, May 4 2017

Status: Fixed (was: Assigned)

Comment 3 by sdantul...@chromium.org, May 8 2017 

wzang@ Could you please provide link to any UI mocks to verify this bug?

Comment 4 by wzang@chromium.org, May 8 2017 

sdantuluri@, the page now looks the same with the 'expected' image.
Expected.png
815 KB View Download
Actual.png
238 KB View Download

Comment 5 by sdantul...@chromium.org, May 8 2017 

Thanks wzang@. 

I am seeing Restart button instead of Powerwash on build 9532.0.0, 60.0.3092.0.
Is it WAI?

Attached screenshot.
FB91C124-067B-441A-A043-FA1EC9041FBD.JPG
2.3 MB View Download

Comment 6 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
Spoke too soon. After clicking Restart, I see Powerwash button on the next screen as expected. Thanks wzang@

9532.0.0, 60.0.3092.0

Comment 7 by wzang@chromium.org, May 8 2017 

sdantuluri@, thanks!
►

Sign in to add a comment