New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715847 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-ec/pd: We don't seem to debounce for tPDDebounce when in Try.SRC state.

Project Member Reported by bleung@chromium.org, Apr 27 2017

Issue description

See this code here:

https://chromium.googlesource.com/chromiumos/platform/ec/+/master/common/usb_pd_protocol.c#1895

This was added when Try.SRC was added to the codebase originally in this CL: https://chromium-review.googlesource.com/#/c/282052/

This seems incorrect. The spec says:
"""
4.5.2.2.9.2 Exiting from Try.SRC State
The port shall transition to Attached.SRC when the SRC.Rd state is detected on exactly one of
the CC1 or CC2 pins for at least tPDDebounce.
"""

So it seems like we do want to wait for tPDDebounce.
 

Comment 1 by bleung@chromium.org, Apr 27 2017

Status: Assigned (was: Unconfirmed)

Comment 2 by vpalatin@google.com, Apr 27 2017

But according to the comment, it was done on purpose, so maybe Scott remembers why ? (eg another delay was actually larger ?)

Sign in to add a comment