Issue metadata
Sign in to add a comment
|
Harmony [Mac] Page Info dialog stays visible after leaving page |
||||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3080.5 OS: macOS 10.12 What steps will reproduce the problem? (1) Go to apple.com (2) Click the security indicator to bring up the page info dialog (3) Cmd-T to create a new tab (or Option-Cmd-Arrow to switch to a different tab) What is the expected result? The page info dialog disappears when I choose a different tab What happens instead? The page info dialog remains visible even though I'm on a completely different tab. This appears to be a regression because I cannot reproduce this problem in 58.0.3029.81. It's unclear if this problem exists in M59. We need a bisect to know.
,
Apr 27 2017
,
Apr 27 2017
Unable to reproduce the issue on MacBook Air-10.12.4 and Mac Retina-10.12.4 using chrome version 60.0.3080.5 and stable version 58.0.3029.81 and canary 60.0.3081.6 with the steps mentioned in comment#0. Please find the attached screen cast and please let us know if anything missed here to reproduce the issue. Thanks.
,
Apr 27 2017
It looks like this problem is a result of the #secondary-ui-md flag being set, so this is not a problem in the current shipping version. cc'ing ellyjones@ for assignment.
,
Apr 28 2017
,
May 23 2017
Is this the same issue? Issue 696136
,
May 23 2017
It looks like it is.
,
May 24 2017
How far are you on this Elly? I barely started looking at this on my side
,
May 24 2017
Reproduced locally. I haven't started this but I can take a look today.
,
May 24 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f582e25a561c090b75b0dc1c96f9d8136ad6991b commit f582e25a561c090b75b0dc1c96f9d8136ad6991b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri May 26 16:03:58 2017 views: dismiss page info bubble on page navigations & tab switches On Mac, this bubble does not consume keyboard events, so global browser hotkeys still work. In those cases, the dialog will not lose focus while navigating or switching tabs, so the page info bubble needs to listen for those changes and dismiss itself. BUG= 715845 , 696136 Change-Id: I1fdd6f5440218cb0d55c2236fa3f9b99212fd087 Reviewed-on: https://chromium-review.googlesource.com/514163 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#475019} [modify] https://crrev.com/f582e25a561c090b75b0dc1c96f9d8136ad6991b/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/f582e25a561c090b75b0dc1c96f9d8136ad6991b/chrome/browser/ui/views/page_info/page_info_bubble_view.h
,
Aug 1 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Apr 27 20171.9 MB
1.9 MB Download