New issue
Advanced search Search tips

Issue 715824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.5% improvement in system_health.common_desktop at 463520:463909

Project Member Reported by samans@chromium.org, Apr 26 2017

Issue description

See the link to graphs below.
 

Comment 1 by samans@chromium.org, Apr 26 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=715824

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgwszSwgkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 27 2017


=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: INFRA_FAILURE

The bisect was able to narrow the range, you can try running with:
  good_revision: e6866222bc8454a9fd7fe2209645484bb4be11fe
  bad_revision : 24f29cd501c22986c8b80fbf4283c734be81c2b9

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : system_health.common_desktop
  Metric       : load:energy_sum/browse_search/browse_search_google_india

Revision             Result                  N
chromium@463519      11.0284 +- 1.84984      14       good
chromium@463714      ---                     ---      build failure
chromium@463715      10.6667 +- 1.07776      14       bad
chromium@463909      10.5843 +- 2.70796      14       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google.india system_health.common_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981208077649504704

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896428703973376


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 27 2017

Cc: wychen@chromium.org
Owner: wychen@chromium.org

=== Auto-CCing suspected CL author wychen@chromium.org ===

Hi wychen@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : wychen
  Commit : c0c8c62aa2e7bfbd81d6ec60d0a99ec33d34fae9
  Date   : Wed Apr 12 02:53:43 2017
  Subject: Connect CopylessPasteExtractor to CopylessPasteServer

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : system_health.common_desktop
  Metric       : load:energy_sum/browse_search/browse_search_google_india
  Change       : 9.67% | 19.0227214963 -> 17.1839651462

Revision             Result                  N
chromium@463519      19.0227 +- 4.24158      20      good
chromium@463714      20.4115 +- 3.12131      6       good
chromium@463812      20.8074 +- 2.86254      9       good
chromium@463861      19.0759 +- 5.73281      14      good
chromium@463885      20.3212 +- 4.27927      9       good
chromium@463897      20.4689 +- 8.92178      13      good
chromium@463903      21.4195 +- 1.87325      6       good
chromium@463906      21.8652 +- 4.50032      6       good
chromium@463908      22.1571 +- 5.11996      6       good
chromium@463909      17.184 +- 5.80215       14      bad       <--

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google.india system_health.common_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981176456177140128

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896428703973376


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
wychen: the bisect wording is confusing! This bug was filed to investigate an IMPROVEMENT in energy usage, and your CL appears to have helped. Note that the results are pretty noisy.

Comment 7 by wychen@chromium.org, Apr 27 2017

Hmm. That CL shouldn't change the behavior on Mac. It only has effect on Android.
Status: Fixed (was: Untriaged)
No action required.

Comment 9 by wychen@chromium.org, May 10 2017

Even though it's nice to learn why we have this performance improvement, the measurement is too noisy to efficiently bisect and reproduce.

Sign in to add a comment