New issue
Advanced search Search tips

Issue 715792 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

about:sandbox doesn't display on Android

Project Member Reported by rsesek@chromium.org, Apr 26 2017

Issue description

Chrome Version: 59.0.3071.25
OS: Android

What steps will reproduce the problem?
(1) Go to about:sandbox

What is the expected result?
See a table underneath the "Sandbox Status" header, showing various data.

What happens instead?
Just the header is shown.

Please use labels and text to provide additional information.
This is caused by doing important work inside a DCHECK.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f29b4a2d08584052867b233984efba57fe9f893c

commit f29b4a2d08584052867b233984efba57fe9f893c
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Apr 27 15:08:49 2017

Fix about:sandbox display on Android.

Don't do work in DCHECKs.

BUG= 715792 
R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2847573002 .
Cr-Commit-Position: refs/heads/master@{#467677}

[modify] https://crrev.com/f29b4a2d08584052867b233984efba57fe9f893c/chrome/renderer/sandbox_status_extension_android.cc

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 1 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63f3e39061dc775dc41a3c0c1be2d19b68bb5434

commit 63f3e39061dc775dc41a3c0c1be2d19b68bb5434
Author: Robert Sesek <rsesek@chromium.org>
Date: Mon May 01 17:23:59 2017

Fix about:sandbox display on Android.

Don't do work in DCHECKs.

BUG= 715792 
R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2847573002 .
Cr-Commit-Position: refs/heads/master@{#467677}
(cherry picked from commit f29b4a2d08584052867b233984efba57fe9f893c)

Review-Url: https://codereview.chromium.org/2848253004 .
Cr-Commit-Position: refs/branch-heads/3071@{#327}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/63f3e39061dc775dc41a3c0c1be2d19b68bb5434/chrome/renderer/sandbox_status_extension_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment