Browser_tests not running on the bots |
|||
Issue descriptionI made a CL to remove proxy resolution, and see if browser_tests passed with it - and while I did run into failures, no browser tests failed. Looking more closely, though, browser_tests didn't even run on any of the trybots. To make absolutely sure this was the case, I added a CHECK(false) to a browser_tests, and it did not fail. CL: https://codereview.chromium.org/2841163002/ (Note that there are a few test failures in 2 or test fixtures, but none of them are browser_tests). In particular, look at the Linux and OSX tests: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/439858 and https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/439515 I think this counts as a recipes issue?
,
Apr 26 2017
I'm not 100% sure what's going on here, but I'm guessing/hoping it's a side effect of bug 714336 , and in particular machenbach's "partial revert" from this morning, https://codereview.chromium.org/2842963003, which I think might've regressed things. I have a CL in the CQ that will hopefully fix bug 714336 , so let's see if that lands and clears things up.
,
Apr 26 2017
Sorry, I did search for browser_tests bugs in the tracker, but somehow overlooked that one, when skimming the list. I'll try again tomorrow, once that CL has landed.
,
Apr 26 2017
The CL just landed; I'll trigger a couple try jobs on your patch and we can see what happens.
,
Apr 27 2017
It looks like the tests are now being run correctly: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/439693 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/440055 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/431096 I'm going to mark this as fixed; please reopen if you see any other oddities.
,
Apr 27 2017
That's great, thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by estaab@chromium.org
, Apr 26 2017Components: Infra>Client>Chrome