New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715756 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

iframe with Google Form URL gets stuck on "processing request"

Reported by j...@johnwheeler.org, Apr 26 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Enter the following code into an HTML document and try opening it.

<html>
<body>
<iframe height="450px" src="https://spreadsheets.google.com/a/highvolumeseller.com/spreadsheet/viewform?formkey=dFVyb1RYcHNsdHlsWTdaWVdxZktjenc6MA#gid=0"></iframe>
</body>
</html>

I have several one other URL that doesn't work and another which does

Here's another which doesn't work:

https://spreadsheets1.google.com/a/highvolumeseller.com/viewform?authkey=CPzniLkO&formkey=dGRncWtmUnpxaWtQaVZDeWJ5Szd4NVE6MQ

This one works:

https://docs.google.com/a/storefrontpro.com/spreadsheet/viewform?formkey=dDhSaUxHeHc1cjdEY2w2QS1QMVpvOHc6MA

What is the expected behavior?
It should load the Google form in an iframe

What went wrong?
The iframe content never loads. The status indicator reads "Processing request" indefinitely.

Net Export Log attached.

Did this work before? Yes Previous release

Chrome version: 58.0.3029.81  Channel: stable
OS Version: OS X 10.12.4
Flash Version: 

I have verified this works on the previous release of Chrome, Safari, and Firefox. The new version seems to be affected.
 
chrome-net-export-log.json
161 KB View Download
Labels: -Pri-2 Needs-Triage-M58 Needs-Bisect Prestable-58.0.3029.81 Pri-1
Components: Internals>Sandbox>SiteIsolation
Labels: -Needs-Bisect -Needs-Triage-M58 hasbisect-per-revision ReleaseBlock-Stable M-59 OS-Linux OS-Windows
Owner: alex...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Mac 10.12.4 and Ubuntu 14.04 using reported version #58.0.3029.81 but the same is not reproducible in the latest canary #60.0.3081.0.

Reverse Bisect Information:
=====================
Good build: 59.0.3037.0  Revision(455955)
Bad Build : 59.0.3036.0  Revision(455621)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/1e2d08a7fc2db1297a7f2a28c40659af534c309e..71e8d307789f1cf492f4803bdceab898e8105a47

From the above change log possible CL that fixed this issue:
Review-Url: https://codereview.chromium.org/2729523003

alexmos@ - Could you please check and merge the fix to M59 if it is a valid candidate.

Note: As it seems to be a recent regression hence, adding label ReleaseBlock-Stable.

Thanks...!!
Issue 715874 has been merged into this issue.
Cc: creis@chromium.org
Adding creis@ (reviewer of the relevant CL) for possible further dispatch since alexmos@ appears to be out.

Comment 5 by creis@chromium.org, Apr 27 2017

Cc: gov...@chromium.org
Oh!  I guess  issue 697513  affected hosted apps as well (since Docs is installed by default as a hosted app), and not just data URLs to plugins.

That bug was introduced in r453800 (58.0.3027.0) and fixed in r455821 (59.0.3037.0).  This means the fix is already present in M59, but not M58.

govind@: Do you want to take this fix (r455821) for M58?  I haven't verified it locally, but I can try.
Cc: ligim...@chromium.org
Labels: M-58
I am able to reproduce this issue in latest M58 -58.0.3029.81, but works fine in all other channels.

Not sure how critical the bug is, able to repro only withe the sample testcase.

Works fine for the below spreadsheets.

https://spreadsheets1.google.com/a/highvolumeseller.com/viewform?authkey=CPzniLkO&formkey=dGRncWtmUnpxaWtQaVZDeWJ5Szd4NVE6MQ

https://docs.google.com/a/storefrontpro.com/spreadsheet/viewform?formkey=dDhSaUxHeHc1cjdEY2w2QS1QMVpvOHc6MA

Adding RBS for tracking purpose.

Comment 8 by creis@chromium.org, Apr 27 2017

Labels: -M-59 Merge-Request-58
Ok, it looks like  issue 697513  did affect redirects to hosted app URLs.  This apparently also caused issue 710668, where Google Calendar is failing to load in an iframe, presumably due to a redirect to Google Calendar, which is also default installed as a hosted app.

The impact of this is that all redirects to hosted app URLs in iframes will not work on M58.  The "spreadsheets.google.com" and "spreadsheets1.google.com" URLs redirect to docs.google.com, so they're affected.  https://docs.google.com/a/storefrontpro.com/spreadsheet/viewform?formkey=dDhSaUxHeHc1cjdEY2w2QS1QMVpvOHc6MA isn't affected because it doesn't redirect, but if you change "docs" to "spreadsheets", it does redirect and is affected.

Given the number of default installed hosted apps, we should definitely merge the fix to M58.  The fix itself has been baking on M59 since March 9 and is small and targeted, so I think it should be low risk.

I'm currently trying to reproduce the bug on a trunk build with the fix reverted, just to manually confirm the CL is exactly what we need.  No luck so far, but it does seem like this is the right CL.

Comment 9 by creis@chromium.org, Apr 27 2017

Issue 710668 has been merged into this issue.
Cc: bhthompson@chromium.org
Labels: OS-Chrome

+ bhthompson@ as issue 710668 was reported on Chrome OS.


Comment 11 by creis@chromium.org, Apr 27 2017

Cc: alex...@chromium.org
Owner: creis@chromium.org
Status: Started (was: Assigned)
I'm building an M58 branch now to use for confirming the fix.

For reference, here's a few more details for understanding the bug:

It looks like "apdfllckaahabafndbhieahigkjlhalf" is the default-installed hosted app for docs.google.com URLs, and "ejjicmeblgpmajnghnpcppodonldlgfn" is the Google Calendar hosted app.

More explicit repro steps:
1) Start Chrome 58 and be sure that PlzNavigate is not enabled.  (There is a BrowserSideNavigation field trial on Canary and Dev which may affect your repro steps.  Use --force-fieldtrials=BrowserSideNavigation/Control to ensure it is disabled.)
2) Ensure the Google Drive hosted app is installed from https://chrome.google.com/webstore/detail/google-drive/apdfllckaahabafndbhieahigkjlhalf.  (Click "Add to Chrome" if it's there.  If it just says "Visit Website," it's already installed.)
3) Visit https://csreis.github.io/tests/cross-site-iframe.html
4) In the DevTools console, run:
navFrame("https://spreadsheets.google.com/a/highvolumeseller.com/spreadsheet/viewform?formkey=dFVyb1RYcHNsdHlsWTdaWVdxZktjenc6MA#gid=0")

It will spin instead of loading the URL.

Comment 12 by creis@chromium.org, Apr 27 2017

My local M58 build has finished, and I can confirm the bug without Alex's r455821 using the steps in comment 11.  When I apply r455821, the bug is fixed.

Shall I merge it?
 Issue 716056  has been merged into this issue.
Labels: -Merge-Request-58 Merge-Approved-58
Approving merge to M58 branch 3029 based on internal group chat and comment #8 & #12.

Comment 15 by creis@chromium.org, Apr 28 2017

Labels: -Merge-Approved-58 merge-merged-3029
Status: Fixed (was: Started)
Merge landed.  I had the old bug number on it, so it didn't get posted here.  Copied below:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0454f5814f0bcd28398d93ec6700fc34adae20a0

commit 0454f5814f0bcd28398d93ec6700fc34adae20a0
Author: Charles Reis <creis@chromium.org>
Date: Fri Apr 28 17:17:15 2017

Fix transfers for data URLs with plugin mime types.

Typically, when a local frame navigates to a data URL, the request is
serviced in the renderer without going up to the browser process.
However, this isn't true for some data URLs, such as those with plugin
mime types.  Those go up to the browser, where they stalled due to
conflicting logic that first decided that a transfer is needed, marked
the current RFH as transferring, but then decided that a process
transfer isn't allowed and kept the load in the current RFH.

When the process transfer is prevented by CanSubframeSwapProcess, the
load will always stay in the current RFH.  This CL tries to recognize
scenarios where this happens for transfers that also starts in the
current RFH, so that we can avoid calling Transfer() for the current
RFH unnecessarily.

BUG=  697513  
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2729523003
Cr-Commit-Position: refs/heads/master@{#455821}
(cherry picked from commit 71e8d307789f1cf492f4803bdceab898e8105a47)

Review-Url: https://codereview.chromium.org/2845223002 .
Cr-Commit-Position: refs/branch-heads/3029@{#781}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/0454f5814f0bcd28398d93ec6700fc34adae20a0/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/0454f5814f0bcd28398d93ec6700fc34adae20a0/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Issue 713896 has been merged into this issue.
Cc: hdodda@chromium.org
Labels: TE-Verified-M58 TE-Verified-58.0.3029.96
Verified the issue on Mac os 10.12.3 , windows 7 and ubuntu 14.04 using chrome M58 #58.0.3029.96 and issue seems fixed and followed below steps to verify :

1. Saved the provided code in comment #0 into a html file and launched it in chrome.
2. Observed the url loaded in the iframe.

Attached screencast for reference.

Adding TE-Verified labels.

Thanks!
715756.mp4
617 KB View Download
Thank you creis@ for fixing the bug. 
Requesting a postmortem for this issue. Please see go/chrome-postmortems for the process to follow.
Hi team,

Any idea when the 58.0.3029.96 refresh will land Chrome OS?
Project Member

Comment 20 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a9cc5af57748545858620aab0e9cd8e24dcc93

commit c1a9cc5af57748545858620aab0e9cd8e24dcc93
Author: alexmos <alexmos@chromium.org>
Date: Fri May 19 00:12:53 2017

Add a test for subframes redirecting to hosted app URLs.

We recently had a regression that reached stable channel because we
had no tests for loading subframes that redirect to hosted app URLs.
This CL adds test coverage for that case.

BUG= 721949 ,  715756 

Review-Url: https://codereview.chromium.org/2891633002
Cr-Commit-Position: refs/heads/master@{#472986}

[modify] https://crrev.com/c1a9cc5af57748545858620aab0e9cd8e24dcc93/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Sign in to add a comment