Add a chromite unit test to enforce VM tests on the pre-cq
Reported by
jrbarnette@chromium.org,
Apr 26 2017
|
|||||
Issue description
There's a default list of pre-cq builders that we use for
testing CLs. It's in cbuildbot/constants.py, and it looks
like this:
# The default list of pre-cq configs to use.
PRE_CQ_DEFAULT_CONFIGS = [
# TODO(ihf): Make caroline or newer vmtest once crbug.com/708715 is fixed.
'caroline-no-vmtest-pre-cq', # skylake kernel 3.18
'daisy_spring-no-vmtest-pre-cq', # arm kernel 3.8
'lumpy-no-vmtest-pre-cq', # sandybridge kernel 3.8
'rambi-pre-cq', # baytrail kernel 4.4 vmtest
'samus-no-vmtest-pre-cq', # broadwell kernel 3.14
'whirlwind-no-vmtest-pre-cq', # brillo
'x86-alex-no-vmtest-pre-cq', # x86 kernel 3.8
]
Recently, and change inadvertently (and silently) removed all
the builders providing VMTest coverage from that list. The
result was bad CLs that should have failed in the pre-CQ failing
instead in the CQ.
We should add a chromite unit test that requires that at least
one builder in the list above has VM test coverage.
,
May 5 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/10f141f30bffbdbd59fdb3d30b29d2750fe8a9ed commit 10f141f30bffbdbd59fdb3d30b29d2750fe8a9ed Author: Richard Barnette <jrbarnette@chromium.org> Date: Mon May 08 19:43:43 2017 Add a unit test to require VM tests in the pre-CQ. This adds a unit test that asserts that at least one builder in the default list of pre-CQ builders includes VM testing. BUG= chromium:715752 TEST=remove `rambi-pre-cq` from the list, see the test fail Change-Id: I3598a36862f300458e1aa043261e68ca3f4a8abf Reviewed-on: https://chromium-review.googlesource.com/493924 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/10f141f30bffbdbd59fdb3d30b29d2750fe8a9ed/cbuildbot/chromeos_config_unittest.py
,
May 22 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jrbarnette@chromium.org
, May 3 2017Status: Started (was: Available)