https://chromium.googlesource.com/chromium/src.git/+/3f2d393a778cf804b6641c27fa8a7ae48cdb8343 fixed browser_tests, interactive_ui_tests and extensions_browsertests to pass with thread restrictions enabled. I didn't have time to fix the chrome-os specific browser_tests. The failures can be seen here: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_rel_ng/413172 Most of these are probably due to a small number of places that need base::ThreadRestrictions::ScopedAllowIO allow_io;
+Zel if someone on your team can take a look.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb8bfc386235afd2f6a504708347b708891f04b2 commit fb8bfc386235afd2f6a504708347b708891f04b2 Author: Sam McNally <sammc@chromium.org> Date: Tue Oct 30 06:51:11 2018 Enable I/O thread restrictions for browser_tests on ChromeOS. Add base::ScopedAllowBlockingForTesting to ChromeOS-only, test-only code doing blocking I/O on the main thread. Bug: 715735 Change-Id: Idee52ce51da5e9edc4f01e86714ae385624fd7f3 Reviewed-on: https://chromium-review.googlesource.com/c/1296936 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#603810} [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/app_mode/fake_cws.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/display/quirks_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/file_manager/file_manager_jstest_base.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/active_directory_test_helper.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/resource_loader_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/saml/saml_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/login/webview_login_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/policy/user_policy_test_helper.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/chromeos/profiles/profile_helper.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/net/chrome_network_delegate_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/policy/cloud/cloud_policy_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/ui/ash/chrome_screenshot_grabber_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/services/file_util/public/cpp/zip_file_creator_browsertest.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chromeos/chromeos_test_utils.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chromeos/components/drivefs/fake_drivefs.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chromeos/dbus/fake_session_manager_client.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/chromeos/network/onc/onc_test_utils.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/components/arc/test/fake_app_instance.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/components/drive/service/fake_drive_service.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/content/public/test/browser_test_base.cc [modify] https://crrev.com/fb8bfc386235afd2f6a504708347b708891f04b2/content/public/test/browser_test_base.h
Comment 1 by jam@chromium.org
, Apr 26 2017