New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 715730 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: May 2017
Cc:
█ meganlindsay@chromium.org
ddorwin@chromium.org
█ ymalik@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocking:
issue 689139
issue 703354



Sign in to add a comment

Provide method of exiting WebVR presentation mode in v0 VR browser

Project Member Reported by cjgrant@chromium.org, Apr 26 2017 
The initial browser has dropped the requirement of a menu mode.  We still need a method of exiting WebVR presentation mode.

The v0 UX spec indicates that pressing the App button should exit presentation (previously, it would bring up the menu, offering a button to exit presentation).

Copying ddorwin@ and meganlindsay@ to confirm the expected behavior here.

Comment 1 by cjgrant@chromium.org, Apr 26 2017

Owner: tiborg@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by cjgrant@chromium.org, Apr 26 2017 

Tibor, please note that David, Megan and Josh are still closing on this.  It sounds like it could be either the app-button press, or app-button + simple menu with back and exit buttons.

Comment 3 by tiborg@chromium.org, Apr 26 2017

Blocking: 689139

Comment 4 by tiborg@chromium.org, Apr 26 2017

Blocking: 703354

Comment 5 by tiborg@chromium.org, May 4 2017

Status: Started (was: Assigned)
The guard rail it is. I.e. when clicking the app button two buttons appear that let the user chose if they want to go back to the presentation or exit the presentation. I'm basing this off Chris' button CL (not committed): crref/h2859073003. Credit is due.

Comment 6 by tiborg@chromium.org, May 4 2017 

Link is: crrev/2859073003

Comment 7 by tiborg@chromium.org, May 5 2017

Labels: M-60

Comment 8 by tiborg@chromium.org, May 8 2017 

New update: app button click exits presentation.
Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea6cba18fb2e07477a7992cc027677f37a9b772e

commit ea6cba18fb2e07477a7992cc027677f37a9b772e
Author: tiborg <tiborg@chromium.org>
Date: Wed May 10 16:41:00 2017

App button click exits WebVR presentation.

BUG= 715730 

Review-Url: https://codereview.chromium.org/2867783002
Cr-Commit-Position: refs/heads/master@{#470605}

[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/ea6cba18fb2e07477a7992cc027677f37a9b772e/chrome/browser/android/vr_shell/vr_shell_gl.cc

Comment 10 by tiborg@chromium.org, May 10 2017

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6ac7322836b02036f2758a16b520b00e1330cb3

commit e6ac7322836b02036f2758a16b520b00e1330cb3
Author: yhirano <yhirano@chromium.org>
Date: Thu May 11 03:12:13 2017

Revert of App button click exits WebVR presentation. (patchset #5 id:80001 of https://codereview.chromium.org/2867783002/ )

Reason for revert:
Causes failures on a MSAN bot.
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440

Original issue's description:
> App button click exits WebVR presentation.
>
> BUG= 715730 
>
> Review-Url: https://codereview.chromium.org/2867783002
> Cr-Commit-Position: refs/heads/master@{#470605}
> Committed: https://chromium.googlesource.com/chromium/src/+/ea6cba18fb2e07477a7992cc027677f37a9b772e

TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715730 

Review-Url: https://codereview.chromium.org/2874103003
Cr-Commit-Position: refs/heads/master@{#470789}

[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/e6ac7322836b02036f2758a16b520b00e1330cb3/chrome/browser/android/vr_shell/vr_shell_gl.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/049fd5ff8ae50270cc8c9994b841c2e4e43b9703

commit 049fd5ff8ae50270cc8c9994b841c2e4e43b9703
Author: yhirano <yhirano@chromium.org>
Date: Thu May 11 03:22:45 2017

Reland of App button click exits WebVR presentation. (patchset #1 id:1 of https://codereview.chromium.org/2874103003/ )

Reason for revert:
I reverted an innocent CL.

Original issue's description:
> Revert of App button click exits WebVR presentation. (patchset #5 id:80001 of https://codereview.chromium.org/2867783002/ )
>
> Reason for revert:
> Causes failures on a MSAN bot.
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440
>
> Original issue's description:
> > App button click exits WebVR presentation.
> >
> > BUG= 715730 
> >
> > Review-Url: https://codereview.chromium.org/2867783002
> > Cr-Commit-Position: refs/heads/master@{#470605}
> > Committed: https://chromium.googlesource.com/chromium/src/+/ea6cba18fb2e07477a7992cc027677f37a9b772e
>
> TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 715730 
>
> Review-Url: https://codereview.chromium.org/2874103003
> Cr-Commit-Position: refs/heads/master@{#470789}
> Committed: https://chromium.googlesource.com/chromium/src/+/e6ac7322836b02036f2758a16b520b00e1330cb3

TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 715730 

Review-Url: https://codereview.chromium.org/2876743002
Cr-Commit-Position: refs/heads/master@{#470792}

[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/049fd5ff8ae50270cc8c9994b841c2e4e43b9703/chrome/browser/android/vr_shell/vr_shell_gl.cc
►

Sign in to add a comment