Save Password infobar is not displayed for walmart.com |
||||||||
Issue descriptionApp Version: 59.0.3071.24 dev iOS Version: 10.3 Device: iPhone, iPad URL: walmart.com Steps to reproduce: 1. Launch Google Chrome 2. Navigate to www.walmart.com 3. Create a new account 4. Enter First Name, Last name & email address & password Observed results: Save Password infobar is not displayed Note: Save Password popup is displayed on Chrome on Mac Expected results: Save Password infobar should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Dolphin/Safari/Atomic: Dolphin: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M57 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M58 Yes Type-bug-regression? No Link to video/image: https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mYjdzb21aXzA5Y1k/view
,
Apr 27 2017
,
Apr 27 2017
,
May 2 2017
,
May 4 2017
,
May 11 2017
walmart.com does not use document.submit.
,
Aug 30 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b4899457a8ee998250867ee56ed154e530c751a commit 1b4899457a8ee998250867ee56ed154e530c751a Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Nov 22 09:41:46 2017 [IOS Password Manager] Improve submission detection. The current heuristics: if there is one button on a password form, let's assume that this is the submit button. But some sites have many buttons in a password form (for example show password). Let's improve heuristics: if there are button[type='submit'], let's assume that this is submit buttons (even there are multiple of them), otherwise let's fallback for the initial heuristics. Bug: 715717 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idfe9d9f76e4e1ff5d80719db63fc2a0864f1e3bc Reviewed-on: https://chromium-review.googlesource.com/781866 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518587} [modify] https://crrev.com/1b4899457a8ee998250867ee56ed154e530c751a/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/1b4899457a8ee998250867ee56ed154e530c751a/ios/chrome/browser/passwords/resources/password_controller.js
,
Nov 22 2017
,
Nov 27 2017
Verified the issue is fixed, Now Save Password infobar is displayed for walmart.com Build: 64.0.3279.0 Canary iOS: 10.3.3,11.2 Devices: iPad, iPhone 8 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdhakshinamoor@chromium.org
, Apr 26 2017