New issue
Advanced search Search tips

Issue 715713 link

Starred by 1 user
Status: Verified
Owner:
cjgrant@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 715620
issue 715665


Sign in to add a comment

Implement an initial read-only URL bar, with Back button, security icon and simple URL

Project Member Reported by vollick@chromium.org, Apr 26 2017 
This will be presented below the content window.

Comment 1 by vollick@chromium.org, Apr 26 2017

Owner: cjgrant@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c

commit 5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c
Author: cjgrant <cjgrant@chromium.org>
Date: Mon May 08 16:41:58 2017

VR: Add initial URL bar element and texture.

This bar is incomplete, but has most fundamentals present. It needs
proper icons, proper hit testing, and refinements to color and sizing.

BUG= 715713 

Review-Url: https://codereview.chromium.org/2862283002
Cr-Commit-Position: refs/heads/master@{#470012}

[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.h
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.h
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/ui_texture.h
[add] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[add] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_elements/textured_element.h
[add] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[add] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c/chrome/browser/android/vr_shell/ui_scene_manager.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cf2a298101b0b2ce018e31be498c13fe61a9ce8

commit 4cf2a298101b0b2ce018e31be498c13fe61a9ce8
Author: cjgrant <cjgrant@chromium.org>
Date: Tue May 09 14:13:14 2017

VR: Wire VrShell UI-related state to the scene manager.

This extends the work started by ymalik@ to clean up cross-thread calls,
and uses the new mechanism to pass the state we need to the UI.

BUG= 715713 

Review-Url: https://codereview.chromium.org/2866853002
Cr-Commit-Position: refs/heads/master@{#470318}

[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/BUILD.gn
[delete] https://crrev.com/7d4ca9132c8d4cdbf1091c992cc1c82437d7c8c0/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/4cf2a298101b0b2ce018e31be498c13fe61a9ce8/chrome/browser/android/vr_shell/vr_shell_gl.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec187eecfd39a18cb94f43132858c2f7b3525cc8

commit ec187eecfd39a18cb94f43132858c2f7b3525cc8
Author: cjgrant <cjgrant@chromium.org>
Date: Wed May 10 04:58:06 2017

VR: Render the current URL and security level on the URL bar.

- Don't refresh the URL bar texture if in WebVR mode.
- Use the appropriate security icon based on level.
- Don't draw any icon if there is no URL.
- Hook up the Back button (currently the whole bar) for testing.

BUG= 715713 

Review-Url: https://codereview.chromium.org/2872773002
Cr-Commit-Position: refs/heads/master@{#470465}

[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/ui_elements/url_bar.h
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/ec187eecfd39a18cb94f43132858c2f7b3525cc8/chrome/browser/android/vr_shell/vr_shell.h

Comment 6 by cjgrant@chromium.org, May 16 2017

Summary: Implement an initial read-only URL bar, with Back button, security icon and simple URL (was: Implement a read-only URL bar)
This issue tracks the initial implementation, which could be considered "fishfood" grade.  It does not track compliance to Enamel's security guidelines - that work will be tracked separately.

Comment 7 by cjgrant@chromium.org, May 16 2017

Status: Fixed (was: Assigned)
Marking fixed, and using these bugs to track security-related improvements:

crbug/722861
crbug/722859

Comment 8 by ddorwin@chromium.org, Jun 6 2017

Labels: Proj-VR-Shell

Comment 9 by vsupruniuk@google.com, Jun 10 2017

Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3125.5
►

Sign in to add a comment