The find bar and menu are also unexpectedly white now while in Incognito.

The issue looks similar to the issue id: 640532. Hence, merging into the issue id: 640532.
Please feel free to undupe if not the case.

Thanks...!!

This bug is not limited to affecting the Omnibox; the "Show all" button on download in Incognito is white, making the white text invisible (see screenshot).

Qt Version 5.7.1 FWIW

Deleted: chromium_incognito_downloadbutton.png 152 KB

	chromium_incognito_downloadbutton.png 152 KB View Download

CC estade, who knows about these things

I see this bug and I think it's a pretty bad regression.

This was broken here: https://codereview.chromium.org/2697513008

The main browser window is supposed to be using NativeThemeDarkAura but it's now falling back to NativeThemeAura.

Surprised we're just finding out about this as that cl landed over 2 months ago.

sky@:
That CL used GetOriginalProfile() to prevent a crash where the incognito profile would go away while there was still an open window that used the profile for theming info:
1. Open browser window
2. Open incognito window
3. Open task manager from incognito window
4. Close incognito window

Maybe we could do this:

* Use the profile verbatim for browser windows
(remove GetOriginalProfile here) https://codereview.chromium.org/2697513008/diff/100001/chrome/browser/ui/views/frame/browser_view.cc

* Add GetOriginalProfile for child windows
(In SetThemeProfileForWindow here) https://codereview.chromium.org/2697513008/diff/100001/chrome/browser/ui/views/chrome_views_delegate.cc

wdyt?

assuming that works, it sounds like a fine solution to me.

Please have the fix ready & merged in to M59 branch by Tuesday [5/9] 4 PM as this is marked as Beta blocker blocking next week's beta release.

Based on offline chat with Tom, he is working on the CL(https://codereview.chromium.org/2862113002/) which isn't in Canary and would prefer to get baked in Canary and Dev before we merge to Beta. 

Note : This shouldn't block us from tomorrows beta and if things looks good we can take the merge in next week beta.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069

commit 488d6999c101d4a2a6b7cb3ad5b0336d7bb54069
Author: thomasanderson <thomasanderson@google.com>
Date: Wed May 10 05:30:36 2017

Linux Aura: Use incognito profile to theme incognito browser windows

This CL sets the theme profile of browser windows to the same as the
actual profile.  The theme profile for children windows will continue
using the original (ie. non-incognito) profile.

This fixes an issue where incognito windows using the classic Aura
theme would use NativeThemeAura instead of NativeThemeDarkAura.

BUG= 715710 
R=sky@chromium.org
CC=estade@chromium.org

Review-Url: https://codereview.chromium.org/2862113002
Cr-Commit-Position: refs/heads/master@{#470478}

[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/chrome/browser/ui/views/native_widget_factory.cc
[delete] https://crrev.com/d69d277c17e3a2a36b281ae887fe1d5a4de7a9d4/chrome/browser/ui/views/theme_profile_key.cc
[delete] https://crrev.com/d69d277c17e3a2a36b281ae887fe1d5a4de7a9d4/chrome/browser/ui/views/theme_profile_key.h
[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/488d6999c101d4a2a6b7cb3ad5b0336d7bb54069/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922ab8befea81359ed483317f012072d2a3253d9

commit 922ab8befea81359ed483317f012072d2a3253d9
Author: thomasanderson <thomasanderson@chromium.org>
Date: Thu May 11 18:38:10 2017

[Merge to M59] Linux Aura: Use incognito profile to theme incognito browser windows

> This CL sets the theme profile of browser windows to the same as the
> actual profile.  The theme profile for children windows will continue
> using the original (ie. non-incognito) profile.
>
> This fixes an issue where incognito windows using the classic Aura
> theme would use NativeThemeAura instead of NativeThemeDarkAura.
>
> BUG= 715710 
> R=sky@chromium.org
> CC=estade@chromium.org
>
> Review-Url: https://codereview.chromium.org/2862113002
> Cr-Commit-Position: refs/heads/master@{#470478}
>

BUG= 715710 
TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2879493005
Cr-Commit-Position: refs/branch-heads/3071@{#516}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/chrome/browser/ui/views/native_widget_factory.cc
[delete] https://crrev.com/e639bd5d4f9cd62ded72a58a8b5adf38c553e67f/chrome/browser/ui/views/theme_profile_key.cc
[delete] https://crrev.com/e639bd5d4f9cd62ded72a58a8b5adf38c553e67f/chrome/browser/ui/views/theme_profile_key.h
[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/922ab8befea81359ed483317f012072d2a3253d9/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Rechecked the issue on Ubuntu 14.04 using build 59.0.3071.61. fix is working as intended. Attached screenshot for the same. Adding TE-verified labels.

Thanks.!

Deleted: Incognito-Classic.png 122 KB

	Incognito-Classic.png 122 KB View Download