Ext4 crypto migration message |
|||||||||||
Issue descriptionThe padding of the ext4 crypto migration message at the sign in screen needs to be fixed.
,
Apr 26 2017
I assume that we want the banner to be horizontally center aligned to the selected user, right?
,
Apr 27 2017
Center horizontally to the screen.
,
Apr 27 2017
Attached are the screenshot. The first two are on dev box (where font might not be right). The last one is from a 2x device. Let me whether they look good. Thanks
,
Apr 27 2017
Looks good to me.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae63c3b97ae7dae1bd784a05e64be5d4393d74d3 commit ae63c3b97ae7dae1bd784a05e64be5d4393d74d3 Author: xiyuan <xiyuan@chromium.org> Date: Thu Apr 27 19:39:36 2017 cros: Update migration banner on login For all screens: - Banner content div fit to text content with max-width 722px. This makes the banner fit text better and gets rid of excessive left/right padding when text is short; - Remove font-size override and use inherited 14px from body; For login screen (where banner is only used for migration message): - Reduce 4px of banner-pod space (16px between banner bottom and the selected user pod with this CL); - Add 4px left/right padding (24px instead of 20px with the CL); BUG= 715706 Review-Url: https://codereview.chromium.org/2849583002 Cr-Commit-Position: refs/heads/master@{#467758} [modify] https://crrev.com/ae63c3b97ae7dae1bd784a05e64be5d4393d74d3/ui/login/account_picker/screen_account_picker.css
,
Apr 27 2017
,
Apr 27 2017
Please tag with applicable OSs. Thanks.
,
Apr 27 2017
Oops. Done. This is for ChromeOS.
,
Apr 27 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd598e6abbca621ff70974844e6d2f06e76ed65a commit cd598e6abbca621ff70974844e6d2f06e76ed65a Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Apr 27 21:44:21 2017 Merge "cros: Update migration banner on login" > For all screens: > - Banner content div fit to text content with max-width 722px. > This makes the banner fit text better and gets rid of excessive > left/right padding when text is short; > - Remove font-size override and use inherited 14px from body; > > For login screen (where banner is only used for migration message): > - Reduce 4px of banner-pod space (16px between banner bottom and > the selected user pod with this CL); > - Add 4px left/right padding (24px instead of 20px with the CL); > > BUG= 715706 > > Review-Url: https://codereview.chromium.org/2849583002 > Cr-Commit-Position: refs/heads/master@{#467758} > (cherry picked from commit ae63c3b97ae7dae1bd784a05e64be5d4393d74d3) Review-Url: https://codereview.chromium.org/2849683002 . Cr-Commit-Position: refs/branch-heads/3071@{#271} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/cd598e6abbca621ff70974844e6d2f06e76ed65a/ui/login/account_picker/screen_account_picker.css
,
Apr 27 2017
,
Apr 28 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
CL is merged to M59 in #11.
,
Jan 22 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by elizabethchiu@chromium.org
, Apr 26 2017