New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715706 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ext4 crypto migration message

Project Member Reported by elizabethchiu@chromium.org, Apr 26 2017

Issue description

The padding of the ext4 crypto migration message at the sign in screen needs to be fixed.
 
Screen Shot 2017-04-26 at 12.10.53 PM.png
285 KB View Download
Labels: -Pri-3 Pri-2

Comment 2 by xiy...@chromium.org, Apr 26 2017

Labels: M-59
Status: Assigned (was: Untriaged)
I assume that we want the banner to be horizontally center aligned to the selected user, right?
Center horizontally to the screen.

Comment 4 by xiy...@chromium.org, Apr 27 2017

Attached are the screenshot. The first two are on dev box (where font might not be right). The last one is from a 2x device.

Let me whether they look good. Thanks
migration_banner_single_user.png
1.3 MB View Download
migration_banner_two_users.png
1.4 MB View Download
migration-banner-two-users-on-device.png
1.5 MB View Download
Looks good to me.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae63c3b97ae7dae1bd784a05e64be5d4393d74d3

commit ae63c3b97ae7dae1bd784a05e64be5d4393d74d3
Author: xiyuan <xiyuan@chromium.org>
Date: Thu Apr 27 19:39:36 2017

cros: Update migration banner on login

For all screens:
- Banner content div fit to text content with max-width 722px.
  This makes the banner fit text better and gets rid of excessive
  left/right padding when text is short;
- Remove font-size override and use inherited 14px from body;

For login screen (where banner is only used for migration message):
- Reduce 4px of banner-pod space (16px between banner bottom and
  the selected user pod with this CL);
- Add 4px left/right padding (24px instead of 20px with the CL);

BUG= 715706 

Review-Url: https://codereview.chromium.org/2849583002
Cr-Commit-Position: refs/heads/master@{#467758}

[modify] https://crrev.com/ae63c3b97ae7dae1bd784a05e64be5d4393d74d3/ui/login/account_picker/screen_account_picker.css

Comment 7 by xiy...@chromium.org, Apr 27 2017

Labels: Merge-Request-59
Please tag with applicable OSs.  Thanks.

Comment 9 by xiy...@chromium.org, Apr 27 2017

Labels: OS-Chrome
Oops. Done. This is for ChromeOS.
Labels: Merge-Approved-59
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 27 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd598e6abbca621ff70974844e6d2f06e76ed65a

commit cd598e6abbca621ff70974844e6d2f06e76ed65a
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Apr 27 21:44:21 2017

Merge "cros: Update migration banner on login"

> For all screens:
> - Banner content div fit to text content with max-width 722px.
>   This makes the banner fit text better and gets rid of excessive
>   left/right padding when text is short;
> - Remove font-size override and use inherited 14px from body;
>
> For login screen (where banner is only used for migration message):
> - Reduce 4px of banner-pod space (16px between banner bottom and
>   the selected user pod with this CL);
> - Add 4px left/right padding (24px instead of 20px with the CL);
>
> BUG= 715706 
>
> Review-Url: https://codereview.chromium.org/2849583002
> Cr-Commit-Position: refs/heads/master@{#467758}
> (cherry picked from commit ae63c3b97ae7dae1bd784a05e64be5d4393d74d3)

Review-Url: https://codereview.chromium.org/2849683002 .
Cr-Commit-Position: refs/branch-heads/3071@{#271}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/cd598e6abbca621ff70974844e6d2f06e76ed65a/ui/login/account_picker/screen_account_picker.css

Status: Fixed (was: Assigned)
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, May 2 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-59
CL is merged to M59 in #11.

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment