New issue
Advanced search Search tips

Issue 715704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Migrate cluster telemetry benchmarks to tools/perf/contrib

Project Member Reported by nedngu...@google.com, Apr 26 2017

Issue description

This is to make it clear that cluster telemetry benchmarks are not meant to be run on perf waterfall & make the ownership clearer.
 
Owner: nedngu...@google.com
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b0d3260589cd8a1328e7d533752619687fb6fa

commit 59b0d3260589cd8a1328e7d533752619687fb6fa
Author: nednguyen <nednguyen@google.com>
Date: Fri May 12 20:28:28 2017

Migrate cluster telemetry benchmarks to tools/perf/contrib/cluster_telemetry/

*Notes to reviewers:
1) Main files to review: tools/perf/cluster_telemetry/OWNERS
2) Logical move includes:
i) Straight move of multipage_skpicture_printer.py,
rasterize_and_record_micro.py, repaint.py, repaint_unittest.py,
repaint_helpers.py, skpicture_printer.py to contrib/cluster_telemetry/
ii) Move part of loading.py contrib/cluster_telemetry/loading_ct.py

Note: this also include removes referencing to repaint module in
benchmark_smoke_unittest. This is actually irrelevant since the repaint module
no longer contains locally runnable benchmarks after https://codereview.chromium.org/2874043003/

BUG= 715704 

Review-Url: https://codereview.chromium.org/2876073003
Cr-Commit-Position: refs/heads/master@{#471431}

[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/benchmark.csv
[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/benchmarks/rasterize_and_record_micro.py
[add] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/OWNERS
[add] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/__init__.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/ct_benchmarks_unittest.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/ct_benchmarks_util.py
[add] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/loading_ct.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/multipage_skpicture_printer.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/page_set.py
[add] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/rasterize_and_record_micro_ct.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/repaint.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/repaint_helpers.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/repaint_unittest.py
[rename] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/contrib/cluster_telemetry/skpicture_printer.py
[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/59b0d3260589cd8a1328e7d533752619687fb6fa/tools/perf/unowned_benchmarks.txt

Status: Fixed (was: Started)

Sign in to add a comment