New issue
Advanced search Search tips

Issue 715697 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 717253
issue 715695



Sign in to add a comment

Allow a ProxyService to use the URLRequestContext that it's serving as a ProxyService for.

Project Member Reported by mmenke@chromium.org, Apr 26 2017

Issue description

Allow a ProxyService to use the URLRequestContext that it's serving as a ProxyService for.  This will make network service configuration a bit simpler, since we don't have to worry about how to configure a global URLRequestContext that nothing actually uses directly, except the ProxyService.

We'll still probably need a sidechannel for the ProxyConfigService, but that can be set up when the URLRequestContext that uses it is configured.
 
Blocking: 717253
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e

commit ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e
Author: mmenke <mmenke@chromium.org>
Date: Wed May 03 16:48:33 2017

Allow ProxyService to share URLRequestContext with everything else.

This CL makes ProxyScriptFetcherImpl use highest priority and
LOAD_IGNORE_LIMITS, and adds an OnShutdown method to ProxyService,
which must be called before teardown when the ProxyService makes
requests using a URLRequestContext that it is also used with.

No consumer currently uses the new functionality.  I plan to
switch IOThread/ProfileIOData to using it in another CL, and
add a call in URLRequestContextStorage's destructor.  May also
be worth making it mandatory as well, though that will involve
more changes.

BUG= 715697 

Review-Url: https://codereview.chromium.org/2845643003
Cr-Commit-Position: refs/heads/master@{#469005}

[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/chromeos/network/dhcp_proxy_script_fetcher_chromeos.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/chromeos/network/dhcp_proxy_script_fetcher_chromeos.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/dhcp_proxy_script_fetcher.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/dhcp_proxy_script_fetcher.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/dhcp_proxy_script_fetcher_win.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/dhcp_proxy_script_fetcher_win.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/mock_proxy_script_fetcher.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/mock_proxy_script_fetcher.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_decider.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_decider.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_decider_unittest.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_fetcher.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_fetcher_impl.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_fetcher_impl.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_script_fetcher_impl_unittest.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_service.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_service.h
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/ed8d7e4383d5dbf7e94291b7960b5a4616b4a45e/net/test/embedded_test_server/default_handlers.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393

commit 0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393
Author: mmenke <mmenke@chromium.org>
Date: Wed May 03 18:40:07 2017

Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext.

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG= 715697 

Review-Url: https://codereview.chromium.org/2841163002
Cr-Commit-Position: refs/heads/master@{#469044}

[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/net/proxy_browsertest.cc
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393/net/test/embedded_test_server/embedded_test_server.cc

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfea205a4f3ebb3f443467fe96c7252ebf375089

commit cfea205a4f3ebb3f443467fe96c7252ebf375089
Author: mmenke <mmenke@chromium.org>
Date: Sat May 13 00:11:06 2017

Add method to init HttpNetworkSession::Params from context bulder params

This method will most likely be temporary, and removed once IOThread's
and ProfileIOData's URLRequestContexts can be configured using a
URLRequestContextBuilder.

BUG= 715697 

Review-Url: https://codereview.chromium.org/2876243002
Cr-Commit-Position: refs/heads/master@{#471501}

[modify] https://crrev.com/cfea205a4f3ebb3f443467fe96c7252ebf375089/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/cfea205a4f3ebb3f443467fe96c7252ebf375089/net/url_request/url_request_context_builder.h

Comment 7 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 8 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/517858d26bcec5cc5ee079063ec3223e3d00bd5a

commit 517858d26bcec5cc5ee079063ec3223e3d00bd5a
Author: Eric Roman <eroman@chromium.org>
Date: Wed Aug 15 00:04:32 2018

Remove mention of the defunct "proxy" URLRequestContext.

Bug:  715697 
Change-Id: Ia64e5e9929a85bccb1a0124a5eff7dd3c72e453a
Reviewed-on: https://chromium-review.googlesource.com/1175144
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583091}
[modify] https://crrev.com/517858d26bcec5cc5ee079063ec3223e3d00bd5a/net/docs/life-of-a-url-request.md

Sign in to add a comment