New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 715691 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Update the chrome.notifications documentation with the Mac OS X updates

Project Member Reported by peter@chromium.org, Apr 26 2017

Issue description

CL upcoming.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4840b4c8969155b9da3ae6f36fce95c3416bd35f

commit 4840b4c8969155b9da3ae6f36fce95c3416bd35f
Author: peter <peter@chromium.org>
Date: Thu Apr 27 11:17:24 2017

Update notification.idl following the Mac OS X changes

BUG= 715691 

Review-Url: https://codereview.chromium.org/2844043002
Cr-Commit-Position: refs/heads/master@{#467636}

[modify] https://crrev.com/4840b4c8969155b9da3ae6f36fce95c3416bd35f/chrome/common/extensions/api/notifications.idl

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dccdf8bfe040e02eb4944fb1a2767ace9a32ce45

commit dccdf8bfe040e02eb4944fb1a2767ace9a32ce45
Author: mattgaunt <mattgaunt@google.com>
Date: Thu Apr 27 15:44:42 2017

Adding macOS notes on the rich notification article

BUG= 715691 

Review-Url: https://codereview.chromium.org/2842293002
Cr-Commit-Position: refs/heads/master@{#467690}

[modify] https://crrev.com/dccdf8bfe040e02eb4944fb1a2767ace9a32ce45/chrome/common/extensions/docs/templates/articles/richNotifications.html

Comment 3 by peter@chromium.org, Apr 27 2017

Labels: Merge-Request-59
Requesting merge for M59. These are documentation-only changes.

Comment 4 by peter@chromium.org, Apr 28 2017

Labels: -OS-Linux OS-Mac
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6b2eea7672a9db9ebc9b9393fdf89e5c2b6747

commit 5f6b2eea7672a9db9ebc9b9393fdf89e5c2b6747
Author: Miguel Garcia <miguelg@chromium.org>
Date: Sat Apr 29 09:45:52 2017

Update notification.idl following the Mac OS X changes

BUG= 715691 

Review-Url: https://codereview.chromium.org/2844043002
Cr-Commit-Position: refs/heads/master@{#467636}
(cherry picked from commit 4840b4c8969155b9da3ae6f36fce95c3416bd35f)

Review-Url: https://codereview.chromium.org/2852843002 .
Cr-Commit-Position: refs/branch-heads/3071@{#308}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/5f6b2eea7672a9db9ebc9b9393fdf89e5c2b6747/chrome/common/extensions/api/notifications.idl

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb8090e34ad98ffc5293cca9ba022482b9d0315

commit 7eb8090e34ad98ffc5293cca9ba022482b9d0315
Author: Miguel Garcia <miguelg@chromium.org>
Date: Sat Apr 29 09:48:49 2017

Adding macOS notes on the rich notification article

BUG= 715691 

Review-Url: https://codereview.chromium.org/2842293002
Cr-Commit-Position: refs/heads/master@{#467690}
(cherry picked from commit dccdf8bfe040e02eb4944fb1a2767ace9a32ce45)

Review-Url: https://codereview.chromium.org/2852763005 .
Cr-Commit-Position: refs/branch-heads/3071@{#309}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/7eb8090e34ad98ffc5293cca9ba022482b9d0315/chrome/common/extensions/docs/templates/articles/richNotifications.html

Cc: miguelg@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment