New issue
Advanced search Search tips

Issue 715674 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Cannot enter VR Browsing Mode by inserting phone into DD headset

Project Member Reported by tiborg@chromium.org, Apr 26 2017

Issue description

Chrome Version: ToT
OS: Android

When you are on a 2D page and insert the phone into the DD headset, the DON flow appears. Then the screen turns black and then you are back at the DON flow screen. LogCat does not show an error or a crash.

Interestingly, if you set the 'enable-vr-shell-dev' command line flag and enter VR through Chrome's menu it works and you end up in VrShell after the DON flow.
 
Labels: -Type-Bug M-60 VR-BBB Pri-1 Type-Bug-Regression
Status: Available (was: Untriaged)
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Owner: tiborg@chromium.org
Status: Assigned (was: Available)

Comment 5 by tiborg@chromium.org, Apr 26 2017

If you press back while you are stuck in the DON flow screen, Chrome crashes with:

Reading native crash info from stdin
Unknown Android release, consider --[no-]packed-relocation-adjustments options
Reading Android symbols from: /usr/local/google/code/clankium/src
Searching for Chrome symbols from within: /usr/local/google/code/clankium/src/out-gn/bot/lib.unstripped:/usr/local/google/code/clankium/src/out-gn/bot/lib:/usr/local/google/code/clankium/src/out-gn/bot
Find ABI:arm
Using toolchain from: /usr/local/google/code/clankium/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-
[FATAL:interface_endpoint_client.cc(166)] Check failed: thread_checker_.CalledOnValidThread(). 

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                               FILE:LINE
  001033f7  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  0008a8d5  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  00161f65  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  00161f0b  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  001faec7  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  v------>  vmaxq_f32                                                                                                                                                                                                                                              /usr/local/google/code/clankium/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/include/arm_neon.h:2798
  v------>  Max                                                                                                                                                                                                                                                    /usr/local/google/code/clankium/src/third_party/skia/src/opts/SkNx_neon.h:162
  v------>  sk_clamp_0_255<(anonymous namespace)::SkNx<4, float> >                                                                                                                                                                                                 /usr/local/google/code/clankium/src/third_party/skia/src/core/SkSRGB.h:31
  v------>  store_2dot2<(Order)1u>                                                                                                                                                                                                                                 /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:573
  0115a949  color_xform_RGBA<(SrcFormat)2u, (DstFormat)6u, (SkAlphaType)3u, (ColorSpaceMatch)0u>                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:889
  v------>  vrecpsq_f32                                                                                                                                                                                                                                            /usr/local/google/code/clankium/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/include/arm_neon.h:3182
  v------>  invert                                                                                                                                                                                                                                                 /usr/local/google/code/clankium/src/third_party/skia/src/opts/SkNx_neon.h:134
  v------>  linear_to_2dot2                                                                                                                                                                                                                                        /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:559
  v------>  store_2dot2_1<(Order)1u>                                                                                                                                                                                                                               /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:588
  0115aa79  color_xform_RGBA<(SrcFormat)2u, (DstFormat)6u, (SkAlphaType)3u, (ColorSpaceMatch)0u>                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:905
  003c927b  ukm::UkmReportingService::RegisterPrefs(PrefRegistrySimple*)                                                                                                                                                                                           /usr/local/google/code/clankium/src/components/ukm/ukm_reporting_service.cc:56
  v------>  store_f16_opaque<(Order)0u>                                                                                                                                                                                                                            /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:657
  0115a121  color_xform_RGBA<(SrcFormat)2u, (DstFormat)8u, (SkAlphaType)1u, (ColorSpaceMatch)0u>                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:889
  v------>  load_rgb_linear_1<(Order)1u>                                                                                                                                                                                                                           /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:471
  0115a179  color_xform_RGBA<(SrcFormat)2u, (DstFormat)8u, (SkAlphaType)1u, (ColorSpaceMatch)0u>                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/skia/src/core/SkColorSpaceXform.cpp:895
  0305ea0b  std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >* rtc::MakeCheckOpString<webrtc::AudioCodecInfo*, webrtc::AudioCodecInfo*>(webrtc::AudioCodecInfo* const&, webrtc::AudioCodecInfo* const&, char const*)  /usr/local/google/code/clankium/src/third_party/webrtc/base/checks.h:132
  03b792af  blink::ThreadedMessagingProxyBase::CountFeature(blink::UseCounter::Feature)                                                                                                                                                                            /usr/local/google/code/clankium/src/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp:81
  03b7931d  blink::ThreadedMessagingProxyBase::CountDeprecation(blink::UseCounter::Feature)                                                                                                                                                                        /usr/local/google/code/clankium/src/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp:86
  0305e1fb  Get10msAudioFromFile                                                                                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/webrtc/voice_engine/file_player.cc:169
  v------>  blink::PersistentBase<blink::ThreadableLoadingContext, (blink::WeaknessPersistentConfiguration)0, (blink::CrossThreadnessPersistentConfiguration)0>::SaveCreationThreadHeap()                                                                          /usr/local/google/code/clankium/src/third_party/WebKit/Source/platform/heap/Persistent.h:287
  v------>  blink::PersistentBase<blink::ThreadableLoadingContext, (blink::WeaknessPersistentConfiguration)0, (blink::CrossThreadnessPersistentConfiguration)0>::PersistentBase()                                                                                  /usr/local/google/code/clankium/src/third_party/WebKit/Source/platform/heap/Persistent.h:45
  v------>  blink::Persistent<blink::ThreadableLoadingContext>::Persistent()                                                                                                                                                                                       /usr/local/google/code/clankium/src/third_party/WebKit/Source/platform/heap/Persistent.h:328
  03b7967d  blink::ThreadedMessagingProxyBase::ThreadedMessagingProxyBase(blink::ExecutionContext*)                                                                                                                                                                /usr/local/google/code/clankium/src/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp:32
  004db609  std::__ndk1::basic_string<unsigned short, base::string16_char_traits, std::__ndk1::allocator<unsigned short> >::append(unsigned short const*, unsigned int)                                                                                            /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/string:2596
  000d5dfd  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  000d5bf5  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  00098f21  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  000988e5  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  010655b5  <unknown>                                                                                                                                                                                                                                              /data/app/org.chromium.chrome-2/oat/arm/base.odex

-----------------------------------------------------

signal 6 (SIGABRT), code -6 in tid 24562 (CrGpuMain)
pid: 24544, tid: 24562, name: CrGpuMain  >>> org.chromium.chrome:privileged_process0 <<<
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
[FATAL:interface_endpoint_client.cc(166)] Check failed: thread_checker_.CalledOnValidThread(). 

Stack Trace:
  RELADDR   FUNCTION   FILE:LINE
  001033f7  <unknown>  /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  0008a8d5  <unknown>  /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  00161f65  <unknown>  /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  00161f0b  <unknown>  /data/app/org.chromium.chrome-2/lib/arm/libchrome.so
  001faec7  <unknown>  /data/app/org.chromium.chrome-2/lib/arm/libchrome.so

-----------------------------------------------------

     r0 00000000  r1 00005ff2  r2 00000006  r3 00000008
     r4 e6e34978  r5 00000006  r6 e6e34920  r7 0000010c
     r8 e6e32b88  r9 e6e32c9c  sl c5f229c4  fp e6e330d0
     ip 00000002  sp e6e32af0  lr e9ff1537  pc e9ff3da0

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                                             FILE:LINE
  00049da0  tgkill+12                                                                                                                                                                                                                                                            /system/lib/libc.so
  00047533  pthread_kill+34                                                                                                                                                                                                                                                      /system/lib/libc.so
  0001d635  raise+10                                                                                                                                                                                                                                                             /system/lib/libc.so
  00019181  __libc_android_abort+34                                                                                                                                                                                                                                              /system/lib/libc.so
  00017048  abort+4                                                                                                                                                                                                                                                              /system/lib/libc.so
  v------>  DebugBreak                                                                                                                                                                                                                                                           /usr/local/google/code/clankium/src/base/debug/debugger_posix.cc:221
  00d8d0ad  base::debug::BreakDebugger()                                                                                                                                                                                                                                         /usr/local/google/code/clankium/src/base/debug/debugger_posix.cc:251
  0034db45  logging::LogMessage::~LogMessage()                                                                                                                                                                                                                                   /usr/local/google/code/clankium/src/base/logging.cc:782
  00424f63  mojo::InterfaceEndpointClient::~InterfaceEndpointClient()                                                                                                                                                                                                            /usr/local/google/code/clankium/src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:166
  00424f09  mojo::InterfaceEndpointClient::~InterfaceEndpointClient()                                                                                                                                                                                                            /usr/local/google/code/clankium/src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:170
  v------>  std::__ndk1::default_delete<mojo::InterfaceEndpointClient>::operator()(mojo::InterfaceEndpointClient*) const                                                                                                                                                         /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2431
  v------>  std::__ndk1::unique_ptr<mojo::InterfaceEndpointClient, std::__ndk1::default_delete<mojo::InterfaceEndpointClient> >::reset(mojo::InterfaceEndpointClient*)                                                                                                           /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630
  004bdec7  mojo::internal::BindingStateBase::Close()                                                                                                                                                                                                                            /usr/local/google/code/clankium/src/mojo/public/cpp/bindings/lib/binding_state.cc:41
  v------>  mojo::internal::BindingState<content::mojom::Child, mojo::RawPtrImplRefTraits<content::mojom::Child> >::~BindingState()                                                                                                                                              /usr/local/google/code/clankium/src/mojo/public/cpp/bindings/lib/binding_state.h:98
  v------>  mojo::Binding<content::mojom::Child, mojo::RawPtrImplRefTraits<content::mojom::Child> >::~Binding()                                                                                                                                                                  /usr/local/google/code/clankium/src/mojo/public/cpp/bindings/binding.h:116
  0141d949  content::ServiceManagerConnectionImpl::IOThreadContext::~IOThreadContext()                                                                                                                                                                                           /usr/local/google/code/clankium/src/content/common/service_manager/service_manager_connection_impl.cc:169
  0141da77  content::ServiceManagerConnectionImpl::IOThreadContext::~IOThreadContext()                                                                                                                                                                                           /usr/local/google/code/clankium/src/content/common/service_manager/service_manager_connection_impl.cc:169
  v------>  base::RefCountedThreadSafe<content::ServiceManagerConnectionImpl::IOThreadContext, base::DefaultRefCountedThreadSafeTraits<content::ServiceManagerConnectionImpl::IOThreadContext> >::DeleteInternal(content::ServiceManagerConnectionImpl::IOThreadContext const*)  /usr/local/google/code/clankium/src/base/memory/ref_counted.h:319
  v------>  base::DefaultRefCountedThreadSafeTraits<content::ServiceManagerConnectionImpl::IOThreadContext>::Destruct(content::ServiceManagerConnectionImpl::IOThreadContext const*)                                                                                             /usr/local/google/code/clankium/src/base/memory/ref_counted.h:275
  v------>  base::RefCountedThreadSafe<content::ServiceManagerConnectionImpl::IOThreadContext, base::DefaultRefCountedThreadSafeTraits<content::ServiceManagerConnectionImpl::IOThreadContext> >::Release() const                                                                /usr/local/google/code/clankium/src/base/memory/ref_counted.h:310
  v------>  scoped_refptr<content::ServiceManagerConnectionImpl::IOThreadContext>::Release(content::ServiceManagerConnectionImpl::IOThreadContext*)                                                                                                                              /usr/local/google/code/clankium/src/base/memory/ref_counted.h:572
  0068c27b  scoped_refptr<content::ServiceManagerConnectionImpl::IOThreadContext>::~scoped_refptr()                                                                                                                                                                              /usr/local/google/code/clankium/src/base/memory/ref_counted.h:473
  0141d121  content::ServiceManagerConnectionImpl::~ServiceManagerConnectionImpl()                                                                                                                                                                                               /usr/local/google/code/clankium/src/content/common/service_manager/service_manager_connection_impl.cc:414
  0141d177  content::ServiceManagerConnectionImpl::~ServiceManagerConnectionImpl()                                                                                                                                                                                               /usr/local/google/code/clankium/src/content/common/service_manager/service_manager_connection_impl.cc:416
  v------>  std::__ndk1::default_delete<content::ServiceManagerConnection>::operator()(content::ServiceManagerConnection*) const                                                                                                                                                 /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2431
  v------>  std::__ndk1::unique_ptr<content::ServiceManagerConnection, std::__ndk1::default_delete<content::ServiceManagerConnection> >::reset(content::ServiceManagerConnection*)                                                                                               /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630
  v------>  std::__ndk1::unique_ptr<content::ServiceManagerConnection, std::__ndk1::default_delete<content::ServiceManagerConnection> >::~unique_ptr()                                                                                                                           /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2598
  03321a0b  ~ChildThreadImpl                                                                                                                                                                                                                                                     /usr/local/google/code/clankium/src/content/child/child_thread_impl.cc:557
  03e3c2af  ~GpuChildThread                                                                                                                                                                                                                                                      /usr/local/google/code/clankium/src/content/gpu/gpu_child_thread.cc:188
  03e3c31b  content::GpuChildThread::~GpuChildThread()                                                                                                                                                                                                                           /usr/local/google/code/clankium/src/content/gpu/gpu_child_thread.cc:189
  v------>  std::__ndk1::default_delete<content::ChildThreadImpl>::operator()(content::ChildThreadImpl*) const                                                                                                                                                                   /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2431
  v------>  std::__ndk1::unique_ptr<content::ChildThreadImpl, std::__ndk1::default_delete<content::ChildThreadImpl> >::reset(content::ChildThreadImpl*)                                                                                                                          /usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630
  033211fb  content::ChildProcess::~ChildProcess()                                                                                                                                                                                                                               /usr/local/google/code/clankium/src/content/child/child_process.cc:90
  03e3c67d  content::GpuProcess::~GpuProcess()                                                                                                                                                                                                                                   /usr/local/google/code/clankium/src/content/gpu/gpu_process.cc:12
  0079e607  content::GpuMain(content::MainFunctionParams const&)                                                                                                                                                                                                                 /usr/local/google/code/clankium/src/content/gpu/gpu_main.cc:278
  00398dfd  content::RunNamedProcessTypeMain(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*)                                                           /usr/local/google/code/clankium/src/content/app/content_main_runner.cc:411
  00398bf3  content::ContentMainRunnerImpl::Run()                                                                                                                                                                                                                                /usr/local/google/code/clankium/src/content/app/content_main_runner.cc:704
  0035bf21  service_manager::Main(service_manager::MainParams const&)                                                                                                                                                                                                            /usr/local/google/code/clankium/src/services/service_manager/embedder/main.cc:449
  v------>  Start                                                                                                                                                                                                                                                                /usr/local/google/code/clankium/src/content/app/android/content_main.cc:48
  0035b8e3  Java_org_chromium_content_app_ContentMain_nativeStart                                                                                                                                                                                                                /usr/local/google/code/clankium/src/out-gn/bot/gen/content/public/android/content_jni_headers/content/jni/ContentMain_jni.h:38
  010655b5  offset 0xfd1000                                                                                                                                                                                                                                                      /data/app/org.chromium.chrome-2/oat/arm/base.odex

Comment 6 by tiborg@chromium.org, Apr 26 2017

Owner: mthiesse@chromium.org
Crash above is irrelevant I think. Fix is here: https://codereview.chromium.org/2840353002
Labels: -M-60 M-59
This regression is present on M-59 as well.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97681b526480ec96c009d815b5bd32899587ea60

commit 97681b526480ec96c009d815b5bd32899587ea60
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Apr 28 02:57:21 2017

VR: Ensure initial paused state is set correctly for VrShellDelegate.

BUG= 715674 

Review-Url: https://codereview.chromium.org/2840353002
Cr-Commit-Position: refs/heads/master@{#467859}

[modify] https://crrev.com/97681b526480ec96c009d815b5bd32899587ea60/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Merge-Request-59
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce177d477b350cfdc11e092ebf4944353b4a4047

commit ce177d477b350cfdc11e092ebf4944353b4a4047
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Mon May 01 14:52:07 2017

VR: Ensure initial paused state is set correctly for VrShellDelegate.

BUG= 715674 

Review-Url: https://codereview.chromium.org/2840353002
Cr-Commit-Position: refs/heads/master@{#467859}
(cherry picked from commit 97681b526480ec96c009d815b5bd32899587ea60)

Review-Url: https://codereview.chromium.org/2853013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#319}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ce177d477b350cfdc11e092ebf4944353b4a4047/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Assigned)

Sign in to add a comment