New issue
Advanced search Search tips

Issue 715664 link

Starred by 1 user
Status: Verified
Owner:
tiborg@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Preserve incognito mode when transitioning into and out of VR mode

Project Member Reported by cjgrant@chromium.org, Apr 26 2017 
This should already work, but we must ensure that through all VR transitions, incognito state is maintained.

This does not imply a visual representation of incognito mode while in VR, but rather that a bug doesn't cause us to leave incognito mode.

Comment 1 by vollick@chromium.org, Apr 26 2017

Labels: hotlist-initial-vr-browser

Comment 2 by vollick@chromium.org, Apr 26 2017

Labels: -hotlist-initial-vr-browser

Comment 3 by tiborg@chromium.org, May 16 2017

Owner: tiborg@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cee228225d5b929b96eac976994a8809cfbff20

commit 5cee228225d5b929b96eac976994a8809cfbff20
Author: vollick <vollick@chromium.org>
Date: Thu May 25 19:59:38 2017

[vr] Introduce ColorScheme

This refactors some colors into a color scheme struct, accessed by
mode. Currently, this only houses a few colors, but it would be a
convenient home for all colors that could vary between normal,
fullscreen and, eventually, incognito modes.

Note:
This incorporates some colors and changes from acondor@ and amp@.

BUG= 715664 

Review-Url: https://codereview.chromium.org/2905013002
Cr-Commit-Position: refs/heads/master@{#474766}

[modify] https://crrev.com/5cee228225d5b929b96eac976994a8809cfbff20/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/5cee228225d5b929b96eac976994a8809cfbff20/chrome/browser/android/vr_shell/color_scheme.cc
[add] https://crrev.com/5cee228225d5b929b96eac976994a8809cfbff20/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/5cee228225d5b929b96eac976994a8809cfbff20/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/5cee228225d5b929b96eac976994a8809cfbff20/chrome/browser/android/vr_shell/ui_scene_manager.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c619c829f502b17a0a71a9d0e5c68df9baff5825

commit c619c829f502b17a0a71a9d0e5c68df9baff5825
Author: vollick <vollick@chromium.org>
Date: Sat May 27 04:11:31 2017

[vr] Add incognito coloring

This changes the background, grid, and URL bar coloring
when in incognito mode.

BUG= 715664 

Review-Url: https://codereview.chromium.org/2902043005
Cr-Commit-Position: refs/heads/master@{#475234}

[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_elements/textured_element.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_elements/ui_element.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/c619c829f502b17a0a71a9d0e5c68df9baff5825/chrome/browser/android/vr_shell/vr_shell.cc

Comment 6 by tiborg@chromium.org, May 29 2017

Status: Fixed (was: Assigned)
Verified that incognito mode is preserved when transitioning.

Comment 7 by vollick@chromium.org, May 29 2017

Labels: Merge-Request-60
Project Member

Comment 8 by sheriffbot@chromium.org, May 29 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, May 29 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af20849d31b972e9c11253b2a96bed7bb6f45ce

commit 2af20849d31b972e9c11253b2a96bed7bb6f45ce
Author: Christopher Grant <cjgrant@google.com>
Date: Mon May 29 19:02:25 2017

[vr] Add incognito coloring

This changes the background, grid, and URL bar coloring
when in incognito mode.

BUG= 715664 

Review-Url: https://codereview.chromium.org/2902043005
Cr-Original-Commit-Position: refs/heads/master@{#475234}
Review-Url: https://codereview.chromium.org/2911943002 .
Cr-Commit-Position: refs/branch-heads/3112@{#18}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_elements/textured_element.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_elements/ui_element.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/2af20849d31b972e9c11253b2a96bed7bb6f45ce/chrome/browser/android/vr_shell/vr_shell.cc

Comment 10 by vsupruniuk@google.com, Jun 9 2017

Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3125.5
►

Sign in to add a comment