Quick note on this: The way the e2e tests are structured at the moment, VrShellTest.java which is supposed to contain the tests that involve the VR browser doesn't have access to the WebVR test framework, so you can't test WebVR and the VR browser together at the same time (e.g. entering presentation while already in the VR browser).

There's a simple refactor out to fix this, and it should be in soon, but if someone wants to get started before then, they can patch https://codereview.chromium.org/2842023002/.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/657dc245082eca1a149709f877f85e5e135996ea

commit 657dc245082eca1a149709f877f85e5e135996ea
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Apr 26 21:46:06 2017

Refactor VR e2e tests

Moves the WebVR test framework out of WebVrTest.java into a new VrTestBase.java
that WebVrTest and VrShellTest both extend instead of
ChromeTabbedActivityTestBase. This is because some VrShell tests in the future
will need to test WebVR as well, such as testing presentation while in the VR
browser.

BUG= 715663 

Review-Url: https://codereview.chromium.org/2842023002
Cr-Commit-Position: refs/heads/master@{#467468}

[modify] https://crrev.com/657dc245082eca1a149709f877f85e5e135996ea/chrome/android/BUILD.gn
[modify] https://crrev.com/657dc245082eca1a149709f877f85e5e135996ea/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[add] https://crrev.com/657dc245082eca1a149709f877f85e5e135996ea/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java
[modify] https://crrev.com/657dc245082eca1a149709f877f85e5e135996ea/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f72a7d6c0adfaf509f04b2b307f016e71ce68578

commit f72a7d6c0adfaf509f04b2b307f016e71ce68578
Author: tiborg <tiborg@chromium.org>
Date: Wed May 03 21:49:47 2017

Adds end-to-end tests for VrShell navigation transitions.

- Adds a new test class, which tests all navigation transitions (e.g. clicking a link) in VrShell end-to-end.

BUG= 715663 

Review-Url: https://codereview.chromium.org/2851313002
Cr-Commit-Position: refs/heads/master@{#469143}

[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/android/BUILD.gn
[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[add] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java
[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/browser/android/vr_shell/vr_shell.h
[add] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/test/data/android/webvr_instrumentation/html/test_navigation_2d_page.html
[add] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/test/data/android/webvr_instrumentation/html/test_navigation_webvr_page.html
[add] https://crrev.com/f72a7d6c0adfaf509f04b2b307f016e71ce68578/chrome/test/data/android/webvr_instrumentation/resources/navigation_e2e.js

Hi Tiborg,

There are several test cases for transition in https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java?dr. Are they enough? Or do you plan to add more? 

We are triaging all VR-Test bugs and wonder if it is ok to close it.

I was actually planning on adding some more. Would you mind if we keep it for now? I can close once this is done or I abandon the idea of implementing them.

It is totally fine to keep it if you plan to add more, just want to confirm it.

Removing Internals>VR component and remapping to Internals>XR

Closing this. Didn't make any progress writing more transition tests and we are doing fine without them.