New issue
Advanced search Search tips

Issue 715661 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Feature

Blocking:
issue 809688



Sign in to add a comment

::first-letter unable to render font-feature-settings properties

Reported by mckinney...@gmail.com, Apr 26 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3080.5 Safari/537.36

Steps to reproduce the problem:
1. Style an element using a font with swash opentype characters
2. apply ::first-letter selector 
3. set font-feature-settings to "swsh"

What is the expected behavior?
Opentype swash characters should be rendered.

What went wrong?
No swash character is used on the first-letter of the element.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 60.0.3080.5  Channel: canary
OS Version: OS X 10.12.4
Flash Version: Shockwave Flash 25.0 r0

Here is a link to see the issue:
http://codepen.io/iamstevemckinney/pen/Kmawop
 
Here is a screenshot of the expected behavior in firefox and safari.
Screen Shot 2017-04-26 at 1.04.11 PM.png
857 KB View Download

Comment 2 by ajha@chromium.org, Apr 27 2017

Labels: Needs-Triage-M60

Comment 3 by ajha@chromium.org, Apr 27 2017

Cc: ajha@chromium.org
Components: Blink>Fonts
Labels: -Needs-Triage-M60 M-60 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest canary(60.0.3082.0) and the latest stable(58.0.3029.81) on Windows-10, Mac OS 10.12.3 and Linux Ubuntu 14.04. This is non regression issue as behaves the same on older version: 30.0.1549.0 with http://codepen.io/iamstevemckinney/pen/Kmawop

Marking this as Untriaged for more inputs on this.

Thank you!

Comment 4 by e...@chromium.org, May 1 2017

Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Status: Available (was: Untriaged)
Blocking: 809688
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d91e2685675f4dd22dc3a3356a154c2eea7cef

commit e9d91e2685675f4dd22dc3a3356a154c2eea7cef
Author: Chris Nardi <cnardi@chromium.org>
Date: Wed Feb 07 17:45:24 2018

Update list of properties whitelisted for first-letter

CSS Pseudo 4 [1] expands the list of properties that can apply to
::first-letter when compared to CSS Selectors 3. Our list was based
primarily off of CSS Selectors 3; update per Pseudo 4. Also whitelist
variables within ::first-letter.

[1]: https://drafts.csswg.org/css-pseudo-4/#first-letter-styling

Bug:  660026 ,  715661 
Change-Id: I950c7881506f8c36c3b917aff0ed2f1709d194ce
Reviewed-on: https://chromium-review.googlesource.com/899859
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535045}
[add] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-property-whitelist.html
[delete] https://crrev.com/5252152ed10bd12bfe8544859e5bae1708906a19/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-letter-expected.txt
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter-expected.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/first-letter-property-whitelist.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Owner: cnardi@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment