New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 21 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Sign in to add a comment
link

Issue 715640: [NetS13nServiceWorker] Service Worker should use URLLoaderFactory for interception instead of hooking at the /net layer

Reported by jam@chromium.org, Apr 26 2017 Project Member

Issue description

The main benefits are:
-to help the network service effort, since networking would run in a separate process and we need to change how web platform features hook networking
-to improve performance (since for subresources, the page can use URLLoaderFactory that is implemented in the same process by the service worker code

(update by falken, Jun 2018):
Design doc:
https://docs.google.com/document/d/1fnuMLsOw77KRPakCgcpAbGQ20SZVChCdkRDEpHPPanw/edit?usp=sharing

Internal design doc (focused on field trial metrics):
https://docs.google.com/document/d/1fkJqZYlJRsHabhi2_D-EhA4MW23-7PatQ4JPli1mXTo/edit#

background:
https://bugs.chromium.org/p/chromium/issues/detail?id=612285#c9
https://docs.google.com/document/d/18MPrKYDuRCov_NPRj_KAXaSu4rBwY3r6YqyVAroEwkg/edit#heading=h.9geozcktw3bn
https://docs.google.com/document/d/1aR_bHEzM3EL7Luk-A4bVbJQhUYk3kxMlNeHD5qYWli8/edit
https://docs.google.com/document/d/1cZLlVClTpCeDxX6wKeumEXQhyV5RmyR4Tx07ykQEXhw/edit
 
Showing comments 126 - 225 of 225 Older

Comment 126 by falken@chromium.org, Jan 23 2018

Blockedon: 804878

Comment 128 by falken@chromium.org, Jan 25 2018

Blockedon: 805805

Comment 129 by falken@chromium.org, Jan 29 2018

Cc: -falken@chromium.org
Owner: falken@chromium.org
Status: Started (was: Assigned)
updating labels

Comment 130 by falken@chromium.org, Jan 29 2018

Blockedon: 806658

Comment 131 by falken@chromium.org, Jan 29 2018

Blockedon: 806674

Comment 132 by falken@chromium.org, Jan 30 2018

Blockedon: 807271

Comment 133 by bugdroid1@chromium.org, Feb 16 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb4eda991ba0b22a7aecf9383a25ed147c89063

commit 9bb4eda991ba0b22a7aecf9383a25ed147c89063
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Feb 16 09:59:07 2018

S13nSW: Use URLLoaderFactory that directly goes to network for SWSubresourceLoader

Instead of using a bundled URLLoaderFactory that can selectively get
multiple factories. The bundled URLLoader factory's default factory
for network (e.g. for http/https) scheme may be replaced with custom
factories (e.g. AppCache one), and SW doesn't want to use it when
falling back.

We used to use 'constraints' flag in SharedURLLoaderFactory to control
this behavior but it's needed only one place where Worker makes
SW-controled fetch. Instead we can just pass the network-direct URLLoader
factory in addition to the bundled one, then we can eliminate the
'constraints' flag too.

R=falken@chromium.org, jam@chromium.org

Bug:  715640 
Change-Id: I1604de28b22c95e0fd79aa230c5f0cb1c59edc85
Reviewed-on: https://chromium-review.googlesource.com/923621
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537271}
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/9bb4eda991ba0b22a7aecf9383a25ed147c89063/content/renderer/shared_worker/embedded_shared_worker_stub.cc

Comment 134 by rdsmith@chromium.org, Feb 16 2018

Cc: -rdsmith@chromium.org

Comment 135 by bugdroid1@chromium.org, Feb 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23482821d11e58e947634e67513fc6a7d42e8c8f

commit 23482821d11e58e947634e67513fc6a7d42e8c8f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Feb 21 03:38:18 2018

service worker: Eliminate DispatchLegacyFetchEvent.

This reduces the difference between non-S13nServiceWorker and S13nServiceWorker
code.

The main change is moving non-S13nSW to use ResourceRequest instead
of ServiceWorkerFetchRequest. The wrinkle is that SWFetchRequest had three
fields for the requeest body which seems like we still must use. Non-S13nSW
makes a blob out of the request body and sends it to the renderer as
blob UUID, blob size, and a Mojo blob ptr. I've retained this behavior by
passing the blob stuff in addition to ResourceRequest.

R=kinuko, shimazu

Bug:  715640 
Change-Id: I633c9b414e53e8acd1f122a69d6ccb4d2d3c2f62
Reviewed-on: https://chromium-review.googlesource.com/925982
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538015}
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/dispatch_fetch_event_params.mojom
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/23482821d11e58e947634e67513fc6a7d42e8c8f/content/renderer/service_worker/service_worker_context_client.h

Comment 136 by bugdroid1@chromium.org, Feb 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb5dd0c3844899742ca80f89e37808b3fb41a08b

commit cb5dd0c3844899742ca80f89e37808b3fb41a08b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Feb 21 11:13:09 2018

S13nServiceWorker: Enable some layout tests.

I suspect these failing expectations are stale. The tests passed 50 runs
locally. Unfortunately we don't have visibility on the flakiness
dashboard to be sure, so just enable them now and see if we get
failures.

R=shimazu

NOTRY: true
Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I934d912514e41a13f937750af929e7cd1b2cdc17
Reviewed-on: https://chromium-review.googlesource.com/927939
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538061}
[modify] https://crrev.com/cb5dd0c3844899742ca80f89e37808b3fb41a08b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 137 by falken@chromium.org, Feb 22 2018

Blockedon: 814583

Comment 138 by falken@chromium.org, Feb 27 2018

Blockedon: 816935

Comment 139 by falken@chromium.org, Mar 2 2018

Description: Show this description

Comment 140 by falken@chromium.org, Mar 2 2018

Description: Show this description

Comment 141 by falken@chromium.org, Mar 12 2018

Blockedon: 820540

Comment 142 by mmenke@chromium.org, Mar 22 2018

Blockedon: 824997

Comment 143 by mmenke@chromium.org, Mar 22 2018

Blockedon: 824970

Comment 144 by mmenke@chromium.org, Mar 22 2018

Blockedon: 824967

Comment 145 by mmenke@chromium.org, Mar 22 2018

Blockedon: -824967

Comment 146 by mmenke@chromium.org, Mar 22 2018

Blockedon: -824970

Comment 147 by mmenke@chromium.org, Mar 22 2018

Blockedon: -824997

Comment 148 by bugdroid1@chromium.org, Apr 2 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1878ead26bac8dac9ab574c5f19baa0438abce2c

commit 1878ead26bac8dac9ab574c5f19baa0438abce2c
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Mon Apr 02 05:45:45 2018

S13nSW: fetch-request-xhr.https.html is no longer timeout

r547407 fixed a deadlock which caused timeout in
fetch-request-xhr.https.html when S13nSW is enabled. Update the
expectation file as it is no longer timed out. Note that the test
is failing currently (w/ or w/o S13nSW).

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If6aca08a4ee513a331772f73e3c7bc24da8114ba
Reviewed-on: https://chromium-review.googlesource.com/989518
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547413}
[modify] https://crrev.com/1878ead26bac8dac9ab574c5f19baa0438abce2c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 149 by bugdroid1@chromium.org, Apr 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba95224765c1a0c6072ef17591d8a3c9e4030b8a

commit ba95224765c1a0c6072ef17591d8a3c9e4030b8a
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Mon Apr 09 12:47:30 2018

S13nSW: Remove external/wpt/service-workers/service-worker/ready.https.html from FlagExpectations

It sometimes crashed before but it seems it's no longer flaky. I ran
the tests under external/wpt/service-workers/service-worker 10 times each
but I couldn't observe crashes (with dcheck_always_on = true).

$ run-webkit-tests --release --iterations=10 --additional-driver-flag=--enable-features=NetworkService external/wpt/service-workers/service-worker/

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I019c942b6caf98223205b9b66cea0ba926838a4e
Reviewed-on: https://chromium-review.googlesource.com/1002792
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549160}
[modify] https://crrev.com/ba95224765c1a0c6072ef17591d8a3c9e4030b8a/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 150 by falken@chromium.org, Apr 10 2018

Blockedon: 830472

Comment 151 by falken@chromium.org, Apr 10 2018

Blockedon: 828331

Comment 152 by bugdroid1@chromium.org, Apr 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6391d19a2bbc914ea208d566e85f31420ea65e55

commit 6391d19a2bbc914ea208d566e85f31420ea65e55
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Apr 12 08:23:09 2018

S13nSW: Improve error messages in ServiceWorkerNewScriptLoader

This fixes failures in
http/tests/serviceworker/chromium/register-error-messages.html

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id089672074157d5e861d7539ee08115cf7b55488
Reviewed-on: https://chromium-review.googlesource.com/1004555
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550102}
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/browser/service_worker/service_worker_new_script_loader.h
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/6391d19a2bbc914ea208d566e85f31420ea65e55/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 153 by bashi@chromium.org, Apr 12 2018

Blockedon: 831998

Comment 154 by bugdroid1@chromium.org, Apr 13 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b

commit b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Apr 13 03:41:18 2018

NetworkService: Remove stale disabled test lines for ServiceWorkerV8CacheStrategies*

These tests no longer exist.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I51cf81a18df2b3740613b0c08c8eceb64424e747
TBR: shimazu
Reviewed-on: https://chromium-review.googlesource.com/1011524
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550497}
[modify] https://crrev.com/b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 155 by bashi@chromium.org, Apr 16 2018

Blockedon: 833241

Comment 156 by bugdroid1@chromium.org, Apr 17 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5db0f42e9792976cf0b15e2781068d849bdf21a

commit e5db0f42e9792976cf0b15e2781068d849bdf21a
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Apr 17 08:10:29 2018

S13nSW: Remove fetch-header-visibility.https.html from FlagExpectations

This test is failing regardless S13nServiceWorker is enabled or not.
We already have an entry in TestExpectation for this test so we can
remove the entry from FlagExpectations. I ran the test 100 times
(--iteration=10 and --repeat-each=10) and confirmed that the test
isn't flaky.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3ef85639001e2f01bc469ac771e479d816c3ea77
Reviewed-on: https://chromium-review.googlesource.com/1013675
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551276}
[modify] https://crrev.com/e5db0f42e9792976cf0b15e2781068d849bdf21a/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 157 by bugdroid1@chromium.org, Apr 17 2018

Project Member
Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b

commit b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Apr 13 03:41:18 2018

NetworkService: Remove stale disabled test lines for ServiceWorkerV8CacheStrategies*

These tests no longer exist.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I51cf81a18df2b3740613b0c08c8eceb64424e747
TBR: shimazu
Reviewed-on: https://chromium-review.googlesource.com/1011524
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550497}
[modify] https://crrev.com/b6a0daf4aeca7a6e52cb85ec07e8c1795b25a73b/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 158 by falken@chromium.org, Apr 20 2018

Blocking: 835448

Comment 159 by falken@chromium.org, Apr 24 2018

Blockedon: 836129

Comment 160 by falken@chromium.org, May 14 2018

Blocking: 842563

Comment 161 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c825d75a1abab124e8817a2f8e991ba593b49b

commit b7c825d75a1abab124e8817a2f8e991ba593b49b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon May 14 18:59:43 2018

Fix ServiceWorkerTest.MimeHandlerView tests with network service.

The tests check that service workers don't see mimeHandler requests. This still is true with the
network service. However the network service path doesn't copy the subresource_overrides_ field for
ServiceWorkerSubresourceLoaderFactory.

As such, adjust the test to account for 2 by just checking that service workers don't see the mime
handler requests.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I25c473ddd50b7641eb4b3da8883cb9998ad8de4a
Reviewed-on: https://chromium-review.googlesource.com/1056607
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558397}
[modify] https://crrev.com/b7c825d75a1abab124e8817a2f8e991ba593b49b/chrome/test/data/extensions/api_test/service_worker/mime_handler_view/background.js
[modify] https://crrev.com/b7c825d75a1abab124e8817a2f8e991ba593b49b/chrome/test/data/extensions/api_test/service_worker/mime_handler_view/mime_handler.js
[modify] https://crrev.com/b7c825d75a1abab124e8817a2f8e991ba593b49b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 162 by bugdroid1@chromium.org, May 22 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc3f5ecc928cdfd98b04b3216286c04dda078ae

commit 8dc3f5ecc928cdfd98b04b3216286c04dda078ae
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue May 22 01:34:35 2018

S13nSW: Set Content-Type for synthesized responses in content_browsertests

Some of content_browsertests are timing out because we haven't supported
mime-sniffing in S13nSW code path yet ( issue 771118 ). These tests wait
for <title> being updated but it doesn't happen when a synthesized
response doesn't have 'Content-Type: text/html'. Probably a right fix
would be to support mime-sniffing but it's better to make these tests
independent from mime-sniffing as these tests do nothing with
mime-sniffing. This CL changes results of following tests:

- ServiceWorkerBrowserTest.FetchPageWithSaveData -> PASS
- ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure -> CRASH
- ServiceWorkerBrowserTest.ResponseFromHTTPServiceWorkerIsNotMarkedAsSecure -> PASS

Following tests are still timing out because of unexpected behavior:

- ServiceWorkerBrowserTest.ImportsBustMemcache
- ServiceWorkerBrowserTest.Reload

Bug:  715640 ,  771118 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I14819f2b39bfa83edf9eb5fcbf9950d72fa5b292
Reviewed-on: https://chromium-review.googlesource.com/1067220
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560448}
[modify] https://crrev.com/8dc3f5ecc928cdfd98b04b3216286c04dda078ae/content/test/data/service_worker/add_save_data_to_title.js
[modify] https://crrev.com/8dc3f5ecc928cdfd98b04b3216286c04dda078ae/content/test/data/service_worker/fetch_event_blob.js
[modify] https://crrev.com/8dc3f5ecc928cdfd98b04b3216286c04dda078ae/content/test/data/service_worker/fetch_event_reload.js
[modify] https://crrev.com/8dc3f5ecc928cdfd98b04b3216286c04dda078ae/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 163 by dxie@chromium.org, May 22 2018

Labels: Proj-Servicification-Canary OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 164 by falken@chromium.org, May 24 2018

Blocking: -842563

Comment 165 by falken@chromium.org, May 24 2018

Blockedon: 842563

Comment 166 by falken@google.com, May 24 2018

Blockedon: 846196

Comment 167 by falken@google.com, May 24 2018

Blockedon: 846197

Comment 168 by falken@chromium.org, May 24 2018

Blockedon: 846228

Comment 169 by falken@chromium.org, May 24 2018

Blockedon: 846229

Comment 170 by falken@chromium.org, May 24 2018

Blockedon: 846235

Comment 171 by falken@chromium.org, May 24 2018

Blockedon: -846197

Comment 172 by falken@chromium.org, May 24 2018

Blockedon: -828331

Comment 173 by falken@chromium.org, May 24 2018

Blockedon: -846196

Comment 174 by falken@chromium.org, May 29 2018

Blockedon: 847322

Comment 175 by falken@chromium.org, Jun 1 2018

Blockedon: 848606

Comment 176 by falken@chromium.org, Jun 1 2018

Blockedon: 848628

Comment 177 by falken@chromium.org, Jun 8 2018

Blockedon: 804682

Comment 178 by falken@chromium.org, Jun 8 2018

Blockedon: 849670

Comment 179 by falken@chromium.org, Jun 8 2018

Blockedon: 850865

Comment 180 by falken@chromium.org, Jun 9 2018

Blocking: 613483

Comment 181 by bugdroid1@chromium.org, Jun 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51370754b992f59efdcd297675630a99d8e36ff

commit e51370754b992f59efdcd297675630a99d8e36ff
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Jun 11 03:09:28 2018

NetS13nServiceWorker: Disable irrelevant interceptor test.

Skip ServiceWorkerNavigationPreloadTest.CanceledByInterceptor.

This test is about ResourceDispatcherHost interceptors and doesn't apply
to the NetworkService world.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6a33bff304c2add06a06f80882ba7fe695b946b7
Reviewed-on: https://chromium-review.googlesource.com/1092613
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565919}
[modify] https://crrev.com/e51370754b992f59efdcd297675630a99d8e36ff/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/e51370754b992f59efdcd297675630a99d8e36ff/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 182 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6086ea3268b84b5b81bc7f04cf16e39eff9e2685

commit 6086ea3268b84b5b81bc7f04cf16e39eff9e2685
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jun 12 02:08:59 2018

NetS13nServiceWorker: Disable irrelevant test for MimeSniffingResourceHandler.

The test was written to test an internal quirk of
MimeSniffingResourceHandler, which isn't used with Network Service, and
service worker won't support MIME sniffing for now.

Also the quirk, OnStartLoadingResponseBody() called before OnReceiveResponse(),
seems to violate the contract in url_loader.mojom anyway.

Bug:  715640 ,  771118 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If9671b3ad0756157064b577693fbea9a520460f6
Reviewed-on: https://chromium-review.googlesource.com/1095061
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566270}
[modify] https://crrev.com/6086ea3268b84b5b81bc7f04cf16e39eff9e2685/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/6086ea3268b84b5b81bc7f04cf16e39eff9e2685/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 183 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/558ff2ed9852d9d9c823f471aca4246ecf0f1000

commit 558ff2ed9852d9d9c823f471aca4246ecf0f1000
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jun 12 02:27:27 2018

service worker: Small cleanups in ServiceWorkerNavigationLoader.

* Remove FallbackToRenderer as CORS isn't needed for navigations.
* Remove ssl_info_ as it's only needed locally in one function.
* Remove FailDueToLostController as it only happens for subresources.

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6aab83459f4f60b078efd4c2c8ad1ddb0dca0500
Reviewed-on: https://chromium-review.googlesource.com/1094845
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566279}
[modify] https://crrev.com/558ff2ed9852d9d9c823f471aca4246ecf0f1000/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/558ff2ed9852d9d9c823f471aca4246ecf0f1000/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/558ff2ed9852d9d9c823f471aca4246ecf0f1000/content/browser/service_worker/service_worker_url_job_wrapper.cc

Comment 184 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be5fb3637b757c2da19f673c61c584202c7d81a

commit 4be5fb3637b757c2da19f673c61c584202c7d81a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jun 12 05:48:34 2018

service worker: Minor refactoring in ServiceWorkerSubresourceLoader.

We don't need to make a copy of the inflight request anymore, since just
ResourceRequest is used. Also use ScopedObserver to be more robust about
removing the loader.

Add some more comments around how we handle both waitUntil() and
respondWith().

Bug:  715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I842a97d2af0424d3b864f64cc8f2693d94c3d63f
Reviewed-on: https://chromium-review.googlesource.com/1096579
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566331}
[modify] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/4be5fb3637b757c2da19f673c61c584202c7d81a/content/renderer/service_worker/service_worker_subresource_loader.h

Comment 185 by falken@chromium.org, Jun 14 2018

Blockedon: 852658

Comment 186 by falken@chromium.org, Jun 14 2018

Description: Show this description

Comment 187 by falken@chromium.org, Jun 14 2018

Blockedon: 850839

Comment 188 by falken@chromium.org, Jun 25 2018

Blockedon: 853635

Comment 189 by falken@chromium.org, Jul 3 2018

Blocking: 853518

Comment 190 by jonr...@chromium.org, Jul 11 2018

Blocking: -794961
No longer blocking Viz testing.

Comment 191 by dxie@chromium.org, Jul 12 2018

Labels: -Pri-2 Pri-1

Comment 192 by dxie@google.com, Jul 17 2018

Labels: -Proj-Servicification-Canary Proj-Servicification
the remaining blockers on the bug are non-canary blocking for network service.

Comment 193 by falken@chromium.org, Jul 20 2018

Blocking: 782958

Comment 194 by dxie@chromium.org, Jul 24 2018

Labels: knon

Comment 195 by dxie@chromium.org, Jul 24 2018

Labels: -knon Hotlist-KnownIssue

Comment 196 by falken@chromium.org, Aug 13

Blockedon: 873061

Comment 197 by falken@chromium.org, Aug 13

Blockedon: 825717

Comment 198 by falken@chromium.org, Aug 13

Blockedon: 873558

Comment 199 by falken@chromium.org, Aug 24

Blockedon: 876161

Comment 200 by falken@chromium.org, Aug 27

Blockedon: 876983

Comment 201 by falken@chromium.org, Aug 29

Blockedon: 878667

Comment 202 by bugdroid1@chromium.org, Aug 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91aec36fd374671c4b88464fef89cc40ccfe33bc

commit 91aec36fd374671c4b88464fef89cc40ccfe33bc
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Aug 31 10:25:46 2018

service worker: Simplify ServiceWorkerNavigationLoader states.

* Remove the Cancelled state so there is only one Completed state.
  The Cancellation state was previously reached by Mojo connection
  error. But it's not needed since WasCanceled() only gets called by
  ServiceWorkerControlleeRequestHandler prior to StartRequest(), which
  means the Mojo connection is not yet established.
* Funnel "cancellation" to CommitCompleted() so there's less transitions
  to Completed.
* Add a unit test about Mojo connection error while the fetch dispatcher
  is alive. Note that the current code passed this test also. The
  test would fail if the InvalidateWeakPtrs() and
  fetch_dispatcher_.reset() lines are removed from the connection
  error handler.

Bug:  715640 
Change-Id: Ibac22ceea5dbc2c11ae7c7d3c47e21cfb9a6d393
Reviewed-on: https://chromium-review.googlesource.com/1198650
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587982}
[modify] https://crrev.com/91aec36fd374671c4b88464fef89cc40ccfe33bc/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/91aec36fd374671c4b88464fef89cc40ccfe33bc/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/91aec36fd374671c4b88464fef89cc40ccfe33bc/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/91aec36fd374671c4b88464fef89cc40ccfe33bc/content/browser/service_worker/service_worker_url_job_wrapper.cc
[modify] https://crrev.com/91aec36fd374671c4b88464fef89cc40ccfe33bc/content/browser/service_worker/service_worker_url_job_wrapper.h

Comment 203 by bugdroid1@chromium.org, Sep 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2adf918227be57efef97a0a2067cb1ff9350add

commit a2adf918227be57efef97a0a2067cb1ff9350add
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Sep 03 02:56:17 2018

service worker: Simplify fallback to network logic.

Remove calling FallbackToNetwork() twice. Refactoring only.

Bug:  715640 
Change-Id: Icc2b702bd19032d0c7d0cb082cbcdd7ed2559853
Reviewed-on: https://chromium-review.googlesource.com/1201624
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588317}
[modify] https://crrev.com/a2adf918227be57efef97a0a2067cb1ff9350add/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/a2adf918227be57efef97a0a2067cb1ff9350add/content/browser/service_worker/service_worker_navigation_loader.cc

Comment 204 by bugdroid1@chromium.org, Sep 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789b9a06d3adc534073c2981a71d07619cf24b20

commit 789b9a06d3adc534073c2981a71d07619cf24b20
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Sep 03 03:15:23 2018

service worker: Refactoring around destroyed URL jobs.

This path is only for the non-S13nSW case because the URLRequestJob is a
weak ptr. Refactoring only.

Bug:  715640 
Change-Id: I886b31f82173cb1bf9e22c950fc5bb0528c43b65
Reviewed-on: https://chromium-review.googlesource.com/1201509
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588319}
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/content/browser/service_worker/service_worker_url_job_wrapper.cc
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/content/browser/service_worker/service_worker_url_job_wrapper.h
[modify] https://crrev.com/789b9a06d3adc534073c2981a71d07619cf24b20/tools/metrics/histograms/enums.xml

Comment 205 by falken@chromium.org, Sep 6

Blockedon: 881225

Comment 206 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c76e91effca628231ce59956bd87cba053491b

commit d0c76e91effca628231ce59956bd87cba053491b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Oct 03 00:18:09 2018

ServiceWorkerServicification: Rename Enabled to Enabled2.

The name is changing due to a change of the server-side configuration.

Bug:  715640 
Change-Id: I6804c7178e7d7e3e2d5c34504435f73ca543a77c
Reviewed-on: https://chromium-review.googlesource.com/c/1256397
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596064}
[modify] https://crrev.com/d0c76e91effca628231ce59956bd87cba053491b/testing/variations/fieldtrial_testing_config.json

Comment 207 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea831fac05987897fc261afcfe60b586af77d77

commit 9ea831fac05987897fc261afcfe60b586af77d77
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Oct 03 06:59:56 2018

service worker: Minor cleanup of outdated comments/names.

ServiceWorkerContainerHostPtr is cloned in several places, not just for
worker fetch contexts now.

Bug:  715640 
Change-Id: I8670b4fea9e215a00b9a1c5788e7ca9a2e8eaca3
Reviewed-on: https://chromium-review.googlesource.com/c/1256466
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596137}
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/service_worker/controller_service_worker_connector.h
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/9ea831fac05987897fc261afcfe60b586af77d77/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc

Comment 208 by bugdroid1@chromium.org, Oct 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a4656491971965bb7eb29205db0d2e48e96d17

commit 58a4656491971965bb7eb29205db0d2e48e96d17
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Oct 04 07:54:58 2018

service worker: Clarify comments about factory bundle.

Bug:  715640 
Change-Id: I130337f41b02b9402e4d27dd6e909212768989bf
Reviewed-on: https://chromium-review.googlesource.com/c/1260745
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596538}
[modify] https://crrev.com/58a4656491971965bb7eb29205db0d2e48e96d17/content/browser/service_worker/embedded_worker_instance.cc

Comment 209 by falken@chromium.org, Oct 9

Blockedon: 892227

Comment 210 by falken@chromium.org, Oct 10

Blockedon: 873551

Comment 211 by falken@chromium.org, Oct 12

Blockedon: 893459

Comment 212 by bashi@chromium.org, Oct 15

Blockedon: 895187

Comment 213 by falken@chromium.org, Oct 17

Blockedon: 896157

Comment 214 by bugdroid1@chromium.org, Oct 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d2271ca9f5f569bbec950f9f0cc98af070ea52f

commit 5d2271ca9f5f569bbec950f9f0cc98af070ea52f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Oct 17 10:12:44 2018

Enable ServiceWorkerServicification by default.

Bug:  715640 , 846235
Change-Id: I49ed8a5a3bc5962cd52e24ab734b00fdfdd7b32d
Reviewed-on: https://chromium-review.googlesource.com/c/1286238
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600337}
[modify] https://crrev.com/5d2271ca9f5f569bbec950f9f0cc98af070ea52f/third_party/blink/common/features.cc

Comment 215 by falken@chromium.org, Oct 19

Blockedon: 896696

Comment 216 by falken@chromium.org, Nov 8

Blockedon: 897060

Comment 217 by shimazu@chromium.org, Dec 6

Summary: [NetS13nServiceWorker] Service Worker should use URLLoaderFactory for interception instead of hooking at the /net layer (was: Service Worker should use URLLoaderFactory for interception instead of hooking at the /net layer)
Let me add [NetS13nServiceWorker] to the title for better searchability of this issue.

Comment 218 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e

commit 31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Dec 06 09:23:24 2018

Flip S13nServiceWorker virtual test to disable the flag

Currently NetS13nServiceWorker is enabled by default, and we don't have tests
excercising non-S13nServiceWorker path. This flips the test to enable
S13nServiceWorker to disabling S13nServiceWorker forcefully.

Bug:  715640 
Change-Id: I8ba3401989dcd9da46e24cd7dc0500f66a200741
Reviewed-on: https://chromium-review.googlesource.com/c/1365050
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614295}
[modify] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/SlowTests
[modify] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/VirtualTestSuites
[add] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
[add] https://crrev.com/31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e/third_party/blink/web_tests/virtual/disabled-service-worker-servicification/http/tests/serviceworker/README.txt
[delete] https://crrev.com/ad058b0d0c95e8cbdf14f26c7886c52d5d1aa110/third_party/blink/web_tests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
[delete] https://crrev.com/ad058b0d0c95e8cbdf14f26c7886c52d5d1aa110/third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/README.txt
[delete] https://crrev.com/ad058b0d0c95e8cbdf14f26c7886c52d5d1aa110/third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/navigation_preload/use-counter-expected.txt

Comment 219 by jam@chromium.org, Dec 12

Can we mark this as fixed now?

Comment 220 by falken@chromium.org, Dec 13

It'd probably jinx it, I was waiting for it to stick in Stable. I'm waiting for Chrome OS to get released to 71 before rolling out completely.

Comment 221 by falken@chromium.org, Jan 9

Blockedon: 907311

Comment 222 by falken@chromium.org, Jan 16

Status: Fixed (was: Started)
This has been on 100% on Stable since late Dec and is enabled by default in the code. Marking fixed.

Comment 223 by falken@chromium.org, Jan 16

Labels: OS-Android

Comment 224 by falken@google.com, Jan 28

Labels: M-71 Target-71

Comment 225 by shimazu@chromium.org, Jan 29

Blocking: 926114
Showing comments 126 - 225 of 225 Older

Sign in to add a comment