Issue 715638 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	isandrk@chromium.org
Closed:	May 2017
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	0
Type:	Bug

Extract MockManifestPermission into its own file

Project Member Reported by isandrk@chromium.org, Apr 26 2017

Issue description

Currently MockManifestPermission is used in two places:
- manifest_permission_set_unittest.cc
- permissions_updater_delegate_chromeos_unittest.cc

and it's copy/pasted in the second place from the first one. As we all know, code duplication is bad therefore refactor MockManifestPermission to have its own file that can be included elsewhere.

Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e

commit 556c3fd74233cb76a64ddbdbc0f1bd61edc0895e
Author: isandrk <isandrk@chromium.org>
Date: Tue May 02 13:07:17 2017

Extracted MockManifestPermission to its own file

BUG= 715638 

Review-Url: https://codereview.chromium.org/2850493002
Cr-Commit-Position: refs/heads/master@{#468612}

[modify] https://crrev.com/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e/extensions/BUILD.gn
[modify] https://crrev.com/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e/extensions/common/permissions/manifest_permission_set_unittest.cc
[add] https://crrev.com/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e/extensions/common/permissions/mock_manifest_permission.cc
[add] https://crrev.com/556c3fd74233cb76a64ddbdbc0f1bd61edc0895e/extensions/common/permissions/mock_manifest_permission.h

Comment 2 by isandrk@chromium.org, May 3 2017

Status: Fixed (was: Assigned)

►

Issue 715638 link

Issue metadata

Extract MockManifestPermission into its own file

Issue description

Comment 1 by bugdroid1@chromium.org, May 2 2017

Comment 1 Deleted

Comment 2 by isandrk@chromium.org, May 3 2017

Comment 2 Deleted

Sign in to add a comment