New issue
Advanced search Search tips

Issue 715637 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Buttons on sign in screen should be sentence case

Project Member Reported by mcirimele@chromium.org, Apr 26 2017

Issue description

Chrome Version: 60.0.3077.0 canary

What is the expected result?
All buttons in the shelf should use sentence case.

What happens instead?
The "g" in "Browse as guest" is capitalized.

See attached screenshot


 
browse-as-guest.jpg
3.6 MB View Download
Cc: wzang@chromium.org
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
+alemate this looks like a pretty small fix?
cc: wzang too as he's been doing a lot of polish bugs.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89cf93013a528e4627bc5d6d06b5889ea4e845d

commit a89cf93013a528e4627bc5d6d06b5889ea4e845d
Author: wzang <wzang@chromium.org>
Date: Thu Jun 15 22:15:19 2017

Revert of Text change on 'Browse as Guest' button (patchset #3 id:40001 of https://codereview.chromium.org/2864793002/ )

Reason for revert:
According to UI-reivew, 'Guest' should be capitalized because it's
treated as a stand in for a user name (e.g. in the status tray) since
it's a special mode.

Original issue's description:
> Text change on 'Browse as Guest' button
>
> BUG= 715637 
>
> Review-Url: https://codereview.chromium.org/2864793002
> Cr-Commit-Position: refs/heads/master@{#470871}
> Committed: https://chromium.googlesource.com/chromium/src/+/a5c71ee3a3a1a08041849f51f7e457e9673014f1

TBR=jcivelli@chromium.org,alemate@chromium.org,msarda@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 715637 

Review-Url: https://codereview.chromium.org/2938743002
Cr-Commit-Position: refs/heads/master@{#479860}

[modify] https://crrev.com/a89cf93013a528e4627bc5d6d06b5889ea4e845d/chrome/app/generated_resources.grd

Comment 4 by wzang@chromium.org, Jun 15 2017

Status: WontFix (was: Assigned)
According to UI-reivew, 'Guest' should be capitalized because it's
treated as a stand in for a user name (e.g. in the status tray) since
it's a special mode.

Sign in to add a comment